The attached patch provides two new actions to simplenews_rules

  1. simplenews_rules_action_subscription_delete ( Delete a subscriber from a selected newsletter )
  2. simplenews_rules_action_subscriber_delete ( Delete a subscriber from all newsletters )

Thanks,

DT

Files: 
CommentFileSizeAuthor
#7 1612508-simplenews-rules-delete-subscription-action-v2.patch1.64 KBdavidwhthomas
PASSED: [[SimpleTest]]: [MySQL] 1,981 pass(es).
[ View ]
#4 1612508-simplenews-rules-delete-subscription-action.patch3.42 KBdavidwhthomas
PASSED: [[SimpleTest]]: [MySQL] 1,796 pass(es).
[ View ]
simplenews-rules-delete-subscription-action.patch2.32 KBdavidwhthomas
PASSED: [[SimpleTest]]: [MySQL] 1,628 pass(es).
[ View ]

Comments

Status:Needs review» Needs work

Looks ok to me, one small coding style issue below. Wondering if we want to reference the unsubscribe action somehow in the description, stating that you should only use delete if you really want that information to be gone completely, or something like that.

+++ b/simplenews_rules/simplenews_rules.rules.incundefined
@@ -109,6 +109,34 @@ function simplenews_rules_rules_action_info() {
+      'label' => t('Delete an e-mail address from a newsletter'),
+      'group' => t('Simplenews'),      'named parameter' => TRUE,

The named parameter part should be on a separate line.

Same for the one below.

Thanks Berdir,

I noticed the named parameter on the same line for the other existing actions, so just kept that format, in case was for a reason.

I'll make some adjustments and post an update.

Wasn't aware that the existing rules were wrong as well. You're welcome to fix that as well while you're at it.

Version:7.x-1.0-beta2» 7.x-1.x-dev
Status:Needs work» Needs review
StatusFileSize
new3.42 KB
PASSED: [[SimpleTest]]: [MySQL] 1,796 pass(es).
[ View ]

Thanks Berdir, there's the updated patch.

Status:Needs review» Fixed

Thanks, commited and pushed!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Needs review
StatusFileSize
new1.64 KB
PASSED: [[SimpleTest]]: [MySQL] 1,981 pass(es).
[ View ]

Hi Berdir,

I found a bug with the earlier rules patch when deleting a subscription from a specific newsletter.

The rule was passing the subscriber 'mail' when it needed to pass the subscriber 'snid'

The attached patch fixes that issue.

Thanks.

I made same changes for simplenews_rules_action_subscription_delete

Patch in #7 works for me on 7.x-1.1; since both dev and 1.1 are probably at the same point right now, guessing this is good to be committed.

Actually @davidwhthomas, is there any reason for the changes in simplenews_mail_spool() that are included in the patch? May want to re-roll with only the changes in simplenews_rules_action_subscription_delete(). Sorry to nitpick, but guessing the maintainer may appreciate that if it is extraneous.