Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Wildcard path matches are still now possible i think.
On (success) conditions those might be important in drupal.
Something different are wildcards related to redirects where you need to consider the match for the redirect url.
#663112: wildcards and tokens for path redirects
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | multivariate_wildcard_match_1614478_7.patch | 3.08 KB | nonsie |
| #6 | multivariate_wildcard_match_1614478_6.patch | 2.76 KB | pivica |
| #2 | multivariate_wildcard_match_1614478_2.patch | 2.61 KB | nonsie |
Comments
Comment #1
pivica CreditAttribution: pivica commentedWe have wildcard support for path mutation and path redirection mutation plugins. No support for wildcard in path success plugin - but it should not be a problem to add.
Comment #2
nonsieAnd here's a possible solution how to allow wildcards and
<front>in path success pluginComment #3
miro_dietikerLooks fine, although not tested yet.
There's still no test coverage possible for all this?
Comment #4
nonsieNo tests so far - still need to be sure if Simpletest supports cookies or not. It seems it's possible now (and it definitely looks doable in D8). Need to spend some time at least attempting to write tests.
Comment #5
miro_dietikerIn D8, all the different internal (wildcard) cases will be tested through well defined APIs with unit tests and possibly only one simpletest case can be enough to test if the plugin generally works as a composite.
I can be wrong, but i didn't see tests yet in D8 that test different user sessions in parallel.
Comment #6
pivica CreditAttribution: pivica commentedHi nonsie,
I tested your patch and it is fine, but while doing this I got an idea why we wouldn't use standard textarea form for entering multiple paths (separated by new line) and then do just simple drupal_match_path() as you proposed (similar like block display is defined per urls). Users should be more use to this UI and also entering multiple success urls is easier.
While testing I also catch one performance bug - in the begging of multivariate_path_sc_boot() when defining current urls if current path does not have alias then drupal_get_path_alias() would return same current system path and we would get double paths in $urls array. This should be fixed now also.
@nonsie can you please check attached patch and do some testing?
Comment #7
nonsieI'm all for making the path matching more in line how core is handling it.
Also re-rolled against current dev and fixed some minor formatting issues
Comment #8
pivica CreditAttribution: pivica commentedAdded with 8f7312e commit.