The current icons for credit cards in the payment options do not have alt tags, making them less accessible.

I have a patch that adds these with a simple alt tag for the card type (e.g. visa, mastercard, etc).

Kim

Files: 
CommentFileSizeAuthor
#3 add-alt-tags-to-card-types-1615754-3.patch587 byteskim.pepper
FAILED: [[SimpleTest]]: [MySQL] 2,193 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#1 add-alt-tags-to-card-types-1615754-1.patch786 byteskim.pepper
PASSED: [[SimpleTest]]: [MySQL] 1,711 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new786 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,711 pass(es).
[ View ]

Patch attached.

Status:Needs review» Needs work

theme('image', ...) should be used here instead of manually creating the img tag, and the explicit styles should be removed and put into the .css. I'd also strongly prefer that this be done in 7.x-3.x first, to ensure that improvements in the code base get propagated forward.

Version:6.x-2.x-dev» 7.x-3.x-dev
Status:Needs work» Needs review
StatusFileSize
new587 bytes
FAILED: [[SimpleTest]]: [MySQL] 2,193 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Added patch against 7.x-3.0-dev

Status:Needs review» Needs work

The last submitted patch, add-alt-tags-to-card-types-1615754-3.patch, failed testing.

Version:7.x-3.x-dev» 6.x-2.x-dev
Assigned:kim.pepper» Unassigned
Status:Needs work» Patch (to be ported)

Ported the code from uc_paypal that does something very similar, which gives better text - e.g. "American Express" instead of "amex".

http://drupalcode.org/project/ubercart.git/commitdiff/4d96430

Status:Patch (to be ported)» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.