Reuse function field_tools_options_entity_bundle and don't show current bundle [#1617816]

Currently the function field_tools_field_clone_form is not using field_tools_options_entity_bundle but it is using the same code. This can be replaced with a call to the function.

Also field_tools_options_entity_bundle will make an option for the current bundle. This should not be an option.

will attach a patch....

Comment	File	Size	Author
#3	field_tools-reuse_options_function-1617816-3.patch	3.1 KB	tedbow
#3
#1	field_tools-reuse_options_function-1617816-1.patch	2.44 KB	tedbow
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow commented 5 June 2012 at 15:49

Status:

Active

» Needs review

File	Size
field_tools-reuse_options_function-1617816-1.patch	2.44 KB

Attached patch - ran through coder review

Comment #2

joachim CreditAttribution: joachim commented 7 June 2012 at 10:09

Status:

Needs review

» Needs work

A few nitpicks below...

(I remember back when I was fairly new to Drupal my co-maintainers nitpicking my patches for layout issues like this, so I appreciate it's probably tedious :/ the coding standards do become an ingrained habit with time though... :)

+++ b/field_tools.admin.inc
@@ -202,16 +196,23 @@ function field_tools_field_clone_form_submit($form, &$form_state) {
  * @return

Needs an extra line before the @return.

+++ b/field_tools.admin.inc
@@ -202,16 +196,23 @@ function field_tools_field_clone_form_submit($form, &$form_state) {
+      // don't show the current bundle

Comment should start with a capital and end with a full stop.

Check this still applies, as I seem to remember tweaking some of the docs in the last patch of your I committed.

I've given you commit access, so once you've tweaked it and checked it and everything, go ahead and commit it :D

Comment #3

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow commented 15 June 2012 at 17:43

File	Size
field_tools-reuse_options_function-1617816-3.patch	3.1 KB

A few nitpicks below...

(I remember back when I was fairly new to Drupal my co-maintainers nitpicking my patches for layout issues like this, so I appreciate it's probably tedious :/ the coding standards do become an ingrained habit with time though... :)

No worries. I just reread through the coding standards. I have been just maintaining a couple modules by my self for a while now so I haven't anyone really looking over my code(though I do use coder review).

I fixed those problems and ran through coder again.

I have attached the updated patch and will commit it.

Thanks