Currently this module is fully dependent on users using feeds via feeds nodes.

It doesn't allow for users using the feeds import forms (the ones at /import/[importer_machine_name]).

This means if each feed importer is going to be used only once you still have to have content type/node for feeds, which is way unnecessary.

For this change we need to:
* Change the schema so that you aren't forced to have an nid, and add another field for feeds importer id and make the primary key a combination of the two. OR there could be two tables.
* Add the feeds_imagegrabber_form() to the feeds formatter settings area somewhere, so imagegrabber can be set up for each feeds importer (then they can be overridden at the feeds node level if desired).
* Change the logic in feeds_imagegrabber_feeds_set_target() to allow for the new feeds importer level settings.

Then the feeds importer pages (the ones at /import/[importer_machine_name]) can use these options.

There is a similar issue for this for drupal 6 at #1063564: Add imagegrabber to feeds-import-form (standalone form)

This is potentially a bug also but it is a major change so making it a new feature.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rooby’s picture

There is a workaround for this at #1618326: Default settings not used, which makes it use the default settings (from the admin setting page of this module) for the non feeds node forms.

This would still be nice to have though in the case you are importing from more than one source and sitewide defaults don't suffice.

rooby’s picture

Assigned: Unassigned » rooby
Issue summary: View changes

I'm going to get this in for the next release, which should be a beta.

rooby’s picture

Status: Active » Needs review
FileSize
9.59 KB

Here is a patch for this.

I changes the database to use the importer_id and feed_nid as the primary key, with the feed_nid being zero for the standalone importer form.
This is consistent with how the feeds_source table works in the main feeds module. Probably best to keep it consistent.

Note that on the standalone form, the settings display below the submit button.

There is a patch for the feeds module that fixes that, at: #2939042: Use actions wrapper for buttons on import form
Although, I'm also thinking of making some changes so that the imagegrabber settings are inside the main feeds fieldset, instead of below them.
I think that would be preferable anyway.

rooby’s picture

Note that I created this patch on top of the patch at: #2244833: Image Grabber doesn't work with latest version of Feeds
I haven't tried but it might not apply without that patch.

rooby’s picture

Reroll for latest dev.

rooby’s picture

Here is a new version that moves the imagegrabber fieldset into the main feeds fieldset, which I think is more logical and gets around the issues with form element weight without necessitating another extra field added to the field ui drag and drop (feeds is already there).