When generating zebra classes please also provide first and last classes to the item elements. This will enable site builder to properly style, for example, a row of guttered images, where the first or last item has to have different side margin than others. As this seems to be a relatively easy addition, please try to make it into 1.x branch

CommentFileSizeAuthor
#10 FirstAndLast-1619784-10.patch4.14 KBlonehorseend
#6 firstlastclasses-1619784-6089974.patch1.05 KBmoniuch
#4 firstlastclasses-1619784-6089974.patch1.17 KBmoniuch
#2 firstlastclasses-1619784-6089974.patch1.19 KBmoniuch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moniuch’s picture

moniuch CreditAttribution: moniuch commented

As I'm not git-savvy enough, please accept my traditional "patch" that works for me. Hope you will not mind applying it to your code.

ds/modules/ds_extras/ds_extras.module

Inside the foreach loop at line 460 I changed the first IF labeled // Field item wrapper.

    if (isset($config['fi'])) {
      $classes = array();
      
      // Determine first-last classes
      reset($variables['items']);
      if($delta === key($variables['items'])) {
        $classes[] = 'first';
      }
      end($variables['items']);
      if($delta === key($variables['items'])) {
        $classes[] = 'last';
      }
      
      // Determine zebra classes
      $classes[] = ($delta % 2 ? 'odd' : 'even');

      $classes_str = implode(' ', $classes);
      if (!empty($config['fi-cl'])) {
        $classes_str .= ' ' . $config['fi-cl'];
      }
      
      $output .= '<' . $fi_wrapper . ' class="' . $classes_str . '">';
    }
moniuch’s picture

moniuch CreditAttribution: moniuch commented
FileSize
firstlastclasses-1619784-6089974.patch1.19 KB
Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented
Status: Active » Needs work

Patch is OK but I have one notice:

+++ b/modules/ds_extras/ds_extras.module
@@ -471,11 +471,27 @@ function theme_ds_field_expert($variables) {
+      $classes = array();
+      ¶
+      // Determine first-last classes
+      reset($variables['items']);
+      if($delta === key($variables['items'])) {
+        $classes[] = 'first';
+      }
+      end($variables['items']);
+      if($delta === key($variables['items'])) {
+        $classes[] = 'last';
+      }
+      ¶
+      // Determine zebra classes
+      $classes[] = ($delta % 2 ? 'odd' : 'even');
+
+      $classes_str = implode(' ', $classes);
       if (!empty($config['fi-cl'])) {
-        $classes .= ' ' . $config['fi-cl'];
+        $classes_str .= ' ' . $config['fi-cl'];
       }
-      $output .= '<' . $fi_wrapper . ' class="' . $classes . '">';
+      ¶

Please, remove extra spaces from the patch. And please set issue status to Needs Review when providing a patch.

moniuch’s picture

moniuch CreditAttribution: moniuch commented
Status: Needs work » Needs review
FileSize
firstlastclasses-1619784-6089974.patch1.17 KB

Thanks, Spleshka, slowly making my progress :)

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented
Status: Needs review » Needs work

According to Drupal coding standards - at the end of comment should be dot :) I'm not sure if it is required for this patch, but if you have free minute - please fix this.

moniuch’s picture

moniuch CreditAttribution: moniuch commented
Status: Needs work » Needs review
FileSize
firstlastclasses-1619784-6089974.patch1.05 KB

As desired :)

swentel’s picture

swentel CreditAttribution: swentel commented
Version: 7.x-1.5 » 7.x-2.x-dev

Needs to go into second branch first - with configuration option (if that's not in yet, not sure). I'm a bit afraid I can't add this by default in the first branch as it might possibly break existing css configurations. To overcome this in the first branch you can create your own field template function though with the hook_ds_field_theme_functions_info() hook.

moniuch’s picture

moniuch CreditAttribution: moniuch commented

In 1.5 I haven't seen any configuration option for zebra classes, so I did not worry about making first/last classes configurable. Also, I thought it would be more intuitive that first-last classes go into the same place as zebra. Hence the patch.

I've been using this patch with no CSS problems. It's just additional classes that should don't break anything.

You changed the version of the issue, but I created the patch against 1.5 and I'm not likely to test 2.x-dev as I'm using only release versions for my productions sites. Therefore, if you are not going to use that patch, simply disregard and close that issue. No offense.
Thanks for the hook info though, might come in handy some day.

jmix’s picture

jmix CreditAttribution: jmix commented

HI ! i'm using 7.x-2.0 and just understood this patch was for 1x...
Is there a simple way to have first / last class with DS ?
Thanks !

lonehorseend’s picture

lonehorseend CreditAttribution: lonehorseend commented
Issue summary: View changes
FileSize
FirstAndLast-1619784-10.patch4.14 KB

Here's a patch against the latest version of 7.2.x. It has the admin functionality so you can select or deselect on a field item basis. Remember to clear your cache before using.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

I'm considering this... Will ask frontend input at work.

bceyssens’s picture

bceyssens
Primary language Dutch
Location Genk 🇧🇪
CreditAttribution: bceyssens commented
Status: Needs review » Fixed

Thanks for the patch lonehorseend
This has been committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.