Using advanced_forum, tagging polls as forum content, this error fires up.

Patch attached.

Related issue in advanced_forum #1621218: Facultative forum definition for other types (scenario explained further there);
Opening this new issue even if #690328: Notice: Undefined property: stdClass::$forum_tid in forum_node_view() exists, because many days have past since.

CommentFileSizeAuthor
#29 1621334-29.patch2.36 KBpoker10
#29 1621334-29_test-only.patch1.77 KBpoker10
#19 notice_undefined-1621334-19.patch598 bytessalvis
#11 D7-forum-notice-1621334-11.patch598 bytesszt
#6 forum-notice-1621334-6.patch685 bytesswentel
#5 forum-notice-1621334.patch661 byteslarowlan
#2 forum-undefined_property.patch627 bytesSebCorbin
#1 forum-undefined_property.patch626 bytesSebCorbin
forum-undefined_property.patch0 bytesSebCorbin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
FileSize
forum-undefined_property.patch626 bytes

Oops, patch was empty

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
FileSize
forum-undefined_property.patch627 bytes

Missing parenthesis

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work
Issue tags: +Needs backport to D7

This needs to be fixed in 8.x first, then backported.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue tags: +Needs tests

tagging

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
Issue tags: -Needs tests +Novice
FileSize
forum-notice-1621334.patch661 bytes

No way we can test this, with clean install of D8 even following steps at #1621218: Facultative forum definition for other types there is no way to create a poll node without nominating the forum term.
This must be a legacy content issue, where poll content exists before forum taxonomy field is added to poll content type.
Happy to patch for cleaner code, but no need for tests.
Re-rolled as 8.x patch

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
forum-notice-1621334-6.patch685 bytes

Rerolled

swentel’s picture

swentel CreditAttribution: swentel commented

related to #1408260: Core Forum Undefined Variable, Undefined Property ?

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
Status: Needs review » Reviewed & tested by the community

Patch is still good for me

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Something should be catching this in the tests...

YesCT’s picture

YesCT CreditAttribution: YesCT commented

@webchick in #5 it was detailed why cannot test for this.

Does anyone have more information to add that will show how this can be tested?

szt’s picture

szt CreditAttribution: szt commented
Version: 8.0.x-dev » 7.x-dev
Issue summary: View changes
Status: Needs work » Needs review
FileSize
D7-forum-notice-1621334-11.patch598 bytes

Backported to D7.

szt’s picture

szt CreditAttribution: szt commented
Issue tags: -Needs backport to D7

just see it was already backported in #2, eh :)

szt’s picture

szt CreditAttribution: szt commented
Version: 7.x-dev » 8.0.x-dev
Status: Needs review » Needs work
szt’s picture

szt CreditAttribution: szt commented
Issue tags: +Needs backport to D7
jmarkel’s picture

jmarkel CreditAttribution: jmarkel as a volunteer commented
Issue tags: -Novice

I am removing the Novice tag from this issue because the existing patch no longer applies - underlying code has changed to the point that forum_node_view() no longer exists. It's not clear that this bug even still exists in D8 - it may now be only a D7 issue.

I’m using this documentation as a source: https://www.drupal.org/core-mentoring/novice-tasks#avoid

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs work » Needs review
FileSize
notice_undefined-1621334-19.patch598 bytes

I see this issue

Notice: Undefined property: stdClass::$forum_tid in forum_node_view() (line 273 of modules/forum/forum.module).

independent of poll and advanced_forum, only by adding an optional taxonomy_forums term reference to a content type other than forum and leaving the reference empty.

_forum_node_check_node_type($node) will then categorize those nodes as potential forum nodes (which is intended), but this causes core to call forum_node_view($node, $view_mode), even if $node->taxonomy_forums is empty and $node->forum_tid not set, which causes this notice.

Reroll #2 for D7 and...

+++ b/modules/forum/forum.module
@@ -263,7 +263,7 @@ function _forum_node_check_node_type($node) {
+  if (_forum_node_check_node_type($node) && !empty($node->forum_tid)) {

... swap the conditions.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

introfini’s picture

introfini CreditAttribution: introfini commented

The patch at #19 fixes those errors for my Drupal 7 installation. Thanks.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Do you by any chance have Forum Access installed?

I found out only a few days ago that this was caused on my D7 site by my use of FA for non-forum nodes, and I just posted a patch that solves the issue in this case: #2958547: Support non-forum nodes with optional forum_taxonomy field

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ivnish’s picture

ivnish CreditAttribution: ivnish commented
Version: 9.2.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

#19 patch works. Please commit

poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -Needs tests, -Needs backport to D7
FileSize
1621334-29_test-only.patch1.77 KB
1621334-29.patch2.36 KB

Thanks, patch #19 works and fixes the problem mentioned here! As it can be simulated also without advanced_forum and poll modules, I have created a test for this specific case in the forum tests, so we would have this covered.

Reuploading the patch #19 (unchanged) with additional test added and test only version.

The last submitted patch, 29: 1621334-29_test-only.patch, failed testing. View results

poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Issue tags: +Pending Drupal 7 commit

Adding a tag for other maintainer review.

  • mcdruid committed b71063cf on 7.x 
    Issue #1621334 by SebCorbin, poker10, szt, larowlan, swentel, salvis:...
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid as a volunteer and at Acquia commented
Status: Needs review » Fixed
Issue tags: -Pending Drupal 7 commit

Thanks for adding the tests, and thanks everybody that contributed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.