Add to Cal option not present for Date formats other than datetime

I have figured this out after spending several hours on it and feeling like a complete idiot that I couldn't install a simple module. The module only works if your date field is a "datetime" field. Mine are "Date (ISO format)" as recommended by Karen S (see http://groups.drupal.org/node/221254).

If you change line 58 in addtocal.module from 'field types' => array('datetime'), to 'field types' => array('date'), then the Add to Cal format option appears, and works as intended. (Also, I found I had to check the "show Add to Cal widget for Past Events" option to get the button to show up on the Event node, so be sure to check that box—I'll file a separate issue for that.)

So I guess this module just needs to be a tiny bit more abstracted. ;) The fix may be as simple as changing line 58 to accept all three allowed date formats, but I don't know whether there are other potential consequences of that change. It seems to be working fine for me, however.

Committed a fix for this.

This formatter should support all three data formats, as do the core date formatters. Need to add back 'datetime' and add 'datestamp'. See date_field_formatter_info().

I change line 58 back to 'datetime', because that is what my field is using but I received the following error when I do. I tried to upgrade to the dev version and cleared my cache several times and I am still receiving the error. I even tried uninstalling and reinstalling the module but nothing worked.

Notice: Undefined offset: 0 in addtocal_field_formatter_view() (line 82 of /home/content/84/9602884/html/sites/all/modules/addtocal/addtocal.module).
Warning: array_key_exists() expects parameter 2 to be array, null given in addtocal_extract_event_info() (line 279 of /home/content/84/9602884/html/sites/all/modules/addtocal/addtocal.module).

Same problems...

Attached patch should restore 'date' support and also adds 'datestamp'. I haven't however tested with a datestamp field.

I just applied the patch cleared my cache. Set add to cal as the format. When I visited the node I received the following error.

Notice: Undefined offset: 0 in addtocal_field_formatter_view() (line 82 of /home/content/84/9602884/html/sites/all/modules/addtocal/addtocal.module).
Warning: array_key_exists() expects parameter 2 to be array, null given in addtocal_extract_event_info() (line 279 of /home/content/84/9602884/html/sites/all/modules/addtocal/addtocal.module).

#13: Thanks - I've applied the patch in 57f8e08.

#14: I believe the error message was due to a lack of content in your date field. I've fixed this in eb3ff00.

I am sorry I am relatively new to drupal, you indicated that you fixed the problem in eb3ff00 and applied the patch in 578e08. What does that mean? Is that a patch? If so, how do I locate it to apply it? Thanks for your help!

@tboornaz — those refer to the Git commits. If you wait a half-day or so after the fix is committed it usually gets rolled into a new dev version, so downloading the latest dev should get you access this fix.

Not working with unix timestamp because date variables are unnecessarily converted

replacing

$start_timestamp = strtotime($start . 'UTC');
$end_timestamp = strtotime($end . 'UTC');

with

$start_timestamp = $start;
$end_timestamp = $end;

temporary fixes the problem, but module needs function to recognize date write type.

@trueapart — don't forget to set the status back to "active" if you need to reopen an issue; otherwise the maintainers may never see your comment.

Last comments are covered by #1953650: Dates in ical format registering as 1969.