Active trail system does not respect whether a menu is set as inactive or preferred using menu_set_active_menu_names()

Here is patch for D8.
It simply adds an extra condition to prevent a menu link from an non-allowed menu from being stored as the most specific link.

A word was missing.

Fixed wrong markup

There you are!
I didn't want to introduce too much change because I thought it wouldn't be appreciated, but if you say so :-)

Extra change: we now initialize $preferred_links[$path] to an empty array so that if no match is found, code is not needlessly run again on the next call.

+ I think tag 'translatable' should be added to the query because it is present in _menu_build_tree(), and again a wrong preferred link could be picked up if query is altered in _menu_build_tree() but not in menu_link_get_preferred().
Should we open a separate issue for this?

I still had problems and I noticed that I had skipped another strange part in my previous patch:

<?php
      // Add any menus not already in the menu name search list.
      if (!in_array($candidate['menu_name'], $menu_names)) {
        $menu_names[] = $candidate['menu_name'];
      }
?>

What???

This updated patch removes it.

There is another bug: menu.module retrieves variable 'menu_default_active_menus' using a different default value from the one used in menu.inc
New patch.
When backporting to D7, we must not forget to add an install update for that.

While writing tests, I found another bug: menu_tree_page_data() should cache separately a menu when it is active and when it is not.

Added tests. Still incomplete though but let's see if they pass.

Tests should be OK now. Let's test the test-only patch and the full one.

Changing title to better reflect the issue.

Fixes wrong mark-up again!

The same patch for D7 (without tests). Let's see if it passes the tests.

Now with the tests: tests only and full patches

Ok patch for D7 works too.
It still lacks the install update part though.
Back to D8 for now.

Re-uploading D8 patches with small improvements on #12:
- added a new condition to select only menu links from active menus
- one comment fix
Tests are unchanged.

Completed patch for D7 (see #16).