you could spare

  • two css files
  • one clearfix
  • one extra class

by putting widgets into a inline object instead of a div

CommentFileSizeAuthor
#6 widgets-remove_float-1629742-6.patch2.04 KByannickoo
#1 widgets-remove_float-1629742-1.patch2.16 KBloominade
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

loominade’s picture

loominade CreditAttribution: loominade commented
FileSize
widgets-remove_float-1629742-1.patch2.16 KB

plus: it also works without css

loominade’s picture

loominade CreditAttribution: loominade commented
Status: Active » Needs review
yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented

Means we can delete following two css files after applying the patch:

  • widgets.css
  • widgets-rtl.css
TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
Category: bug » feature

Thanks for the patch. I want to research this more. I am moving it to a feature request.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Needs review » Needs work 
+++ b/widgets.moduleundefined
@@ -1156,8 +1155,13 @@ function theme_widgets_set_view($variables) {
+	        $pre = "<$tag id=\"widgets-element-" . $element['name'] . '" class="widgets widgets-element widgets-element-' . $style . ' widgets-style-' . $style . '">';

Oh, there is a tabulator and whitespaces.

+++ b/widgets.moduleundefined
@@ -1156,8 +1155,13 @@ function theme_widgets_set_view($variables) {
+	        $post = "</$tag>";          		¶

Same here.

+++ b/widgets.moduleundefined
@@ -1156,8 +1155,13 @@ function theme_widgets_set_view($variables) {
+	        $post = "</$tag>";          		¶

And whitespaces with tabulator.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Needs work » Needs review
FileSize
widgets-remove_float-1629742-6.patch2.04 KB

Fixed #5.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Title: don't use float » HTML inline objects instead of floating them in CSS
Assigned: loominade » Unassigned