Default return value from EntityInterface::label(), Entity::label(), entity_label() does not match [#1629924]

Split of from #1616952: Add a langcode parameter to EntityInterface::label()

The default value for 'label not defined / label not found" in EntityInterface::label(), Entity::label(), entity_label() does not match.

Docs in EntityInterface::label(): NULL
Entity::label(): FALSE
entity_label(): FALSE

Whats the right value? FALSE or NULL?

Comment	File	Size	Author
#2	entity-label-default-1629924-2.patch	676 bytes	Berdir
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fubhy CreditAttribution: fubhy commented 12 June 2012 at 17:56

I would prefer NULL instead of FALSE. When invoking entity_label() we are not asking for whether the entity has a label or not so a boolean as a return value doesn't seem right to me. If the label is undefined (by definition) we should return NULL - If the label is empty (not set) we should return an empty string.