As found by @droplet in #1452188: New UI for string translation, long month names in locale.datepicker.js in Drupal 8 do not use context for long month names, and therefore the long month names get recorded for translation (and used translated) without their proper context. Drupal 8 did add context support for JS translation that was missing in Drupal 7 (in #488496: Implement missing msgctx context in JS translation for feature parity with t()), so it should not be possible to add the 'Long month name' context to the JS strings in locale.datepicker.js now and close this bug.
Comment | File | Size | Author |
---|---|---|---|
#3 | 1634190-fix-long-month-context-js-3.patch | 1.51 KB | LoMo |
Comments
Comment #1
Gábor HojtsyI tagged this novice. http://drupal.org/node/1323152 should have code examples on how to add the Long month name context :)
Comment #2
LoMo CreditAttribution: LoMo commentedAll right... I'll work on that. :-)
Comment #3
LoMo CreditAttribution: LoMo commentedHopefully this patch works. Needs review. :-)
Comment #4
Gábor HojtsyYes, looks great. As said, not backportable to Drupal 7, this is new capability in Drupal 8 in JS (in Drupal 7 it is only in PHP).
Comment #5
webchickCool, I will take your word for it on this that the weird empty array stuff is kosher. ;)
Committed and pushed to 8.x; thanks!
Comment #6
Gábor HojtsyThanks, removing sprint tag.