Move date format translation functions from locale to system

I think this looks good. The schema is already in system module and although it is keyed by locale, etc. we will hopefully covert this to CMI later, so there is no point to touch any of the code outside of putting it at its true place :) Only one thing we should possibly discuss AFAIS. Otherwise looks good.

+++ b/core/modules/system/system.moduleundefined
@@ -1110,6 +1113,36 @@ function system_menu() {
+  // Localize date formats.
+  if (module_exists('language')) {
+    $items['admin/config/regional/date-time/locale'] = array(

We need to figure out if we need to do this with a module exists or put the same thing in an access callback for the page.

Does not apply, should be rolled against latest Drupal 8!

The code basically renames and moves things around, and this code is going to be further cleaned up when being converted to CMI, so I don't think we should do any further cleanup here. This is purely about moving the functions/tests to their right place, where its schema and API is.

Needs work for the rename, needs review for the module_exists().

+++ b/core/modules/system/lib/Drupal/system/Tests/DateFormats/LocaleDateFormatsTest.phpundefined
@@ -0,0 +1,82 @@
+<?php
+
+/**
+ * @file
+ * Definition of Drupal\locale\Tests\LocaleDateFormatsTest.
+ */
+
+namespace Drupal\system\Tests\DateFormats;
+
+use Drupal\simpletest\WebTestBase;
+
+/**
+ * Functional tests for localizing date formats.
+ */
+class LocaleDateFormatsTest extends WebTestBase {

Should not be named "Locale..." if its not in locale. I'd name it DateFormatsLanguageTest

+++ b/core/modules/system/system.moduleundefined
@@ -1110,6 +1113,36 @@ function system_menu() {
+
+  // Localize date formats.
+  if (module_exists('language')) {
+    $items['admin/config/regional/date-time/locale'] = array(
+      'title' => 'Localize',

I'd value more feedback on what people think this is better vs. making an access callback which wraps the module_exists() instead. The menu cache is rebuilt when modules get enabled either way, the behavior is the same.

Looks good, just one thing now :)

+++ b/core/modules/locale/locale.moduleundefined
index 0000000..635d70f
--- /dev/null

--- /dev/null
+++ b/core/modules/system/lib/Drupal/system/Tests/System/DateFormatsLanguageTest.phpundefined

+++ b/core/modules/system/lib/Drupal/system/Tests/System/DateFormatsLanguageTest.phpundefined
+++ b/core/modules/system/lib/Drupal/system/Tests/System/DateFormatsLanguageTest.phpundefined
@@ -0,0 +1,82 @@

@@ -0,0 +1,82 @@
+<?php
+
+/**
+ * @file
+ * Definition of Drupal\system\Tests\System\DateFormatLocalizeTest.
+ */
+
+namespace Drupal\system\Tests\System;
+
+use Drupal\simpletest\WebTestBase;
+
+/**
+ * Functional tests for localizing date formats.
+ */
+class DateFormatsLanguageTest extends WebTestBase {

Comment in @file has wrong namespace name mentioned.

Get it tested.

Patch is also 3k smaller than previous patches. Did you forget to add/remove a file?

Now looks great, thanks. Does not miss the testfile anymore :)

Thanks, moving off sprint.