Warning on enabled cache and no JS added [#1636024]

If there were no calls to drupal_add_js() with non-empty data, the settings array is not set and the following notices and warning appear on the line #215 of views_plugin_cache.inc (in views_plugin_cache->gather_headers() ):

Undefined index: settings
Undefined index: settings
array_diff_assoc(): Argument #1 is not an array

Comment	File	Size	Author
#3	views-1636024-3.patch	1.95 KB	Dmitriy.trt
#3
#1	views-1636024-1.patch	1.18 KB	Dmitriy.trt
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Dmitriy.trt CreditAttribution: Dmitriy.trt commented 15 June 2012 at 07:38

Status:

Active

» Needs review

File	Size
views-1636024-1.patch	1.18 KB

Fix for this problem.

Comment #2

dawehner

German

CreditAttribution: dawehner commented 15 June 2012 at 08:46

This looks pretty fine, not sure whether this might be worth to write a test for that.

Comment #3

Dmitriy.trt CreditAttribution: Dmitriy.trt commented 15 June 2012 at 12:46

File	Size
views-1636024-3.patch	1.95 KB

Found a workaround in cache tests to suppress warnings described above. New patch removes this workaround.

I think the test for this problem is not necessary. The test from which I've removed the workaround will fail anyway because of warnings if the problem appear again in the future. But I could write a separate test if you think we really need it here.