If there were no calls to drupal_add_js() with non-empty data, the settings array is not set and the following notices and warning appear on the line #215 of views_plugin_cache.inc (in views_plugin_cache->gather_headers() ):

  • Undefined index: settings
  • Undefined index: settings
  • array_diff_assoc(): Argument #1 is not an array
Files: 
CommentFileSizeAuthor
#3 views-1636024-3.patch1.95 KBDmitriy.trt
PASSED: [[SimpleTest]]: [MySQL] 1,451 pass(es).
[ View ]
#1 views-1636024-1.patch1.18 KBDmitriy.trt
PASSED: [[SimpleTest]]: [MySQL] 1,451 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.18 KB
PASSED: [[SimpleTest]]: [MySQL] 1,451 pass(es).
[ View ]

Fix for this problem.

This looks pretty fine, not sure whether this might be worth to write a test for that.

StatusFileSize
new1.95 KB
PASSED: [[SimpleTest]]: [MySQL] 1,451 pass(es).
[ View ]

Found a workaround in cache tests to suppress warnings described above. New patch removes this workaround.

I think the test for this problem is not necessary. The test from which I've removed the workaround will fail anyway because of warnings if the problem appear again in the future. But I could write a separate test if you think we really need it here.

Status:Needs review» Fixed

Nice! This looks fine, lets get it in.

Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.