Notice: Undefined index: commerce_payment in commerce_payment_pane_checkout_form() [#1643996]

Hi,

I'm actually not sure whether it's a bug report or a support request.
On the checkout form, I have some fancy ajax tricks reloading some parts, and apparently the payment pane is refreshed too (I don't seem to do any action, so I suppose it's a standard DrupalCommerce behaviour). The problem is that $form_values contains only the related values for a part of the form, there is nothing related to the payment pane, and the following error happens:
Notice: Undefined index: commerce_payment dans commerce_payment_pane_checkout_form() (line 79 in /commerce/modules/payment/includes/commerce_payment.checkout_pane.inc).

Then, when I actually submit the payment part by submitting the whole form, the famous "EntityMetadataWrapperException" happens.

If I'm doing something wrong, can you help me fix it? Is there something peculiar to do when using ajax on some parts of the form.

Comment	File	Size	Author
#1	commerce_1643996_prevent_payment_notice.patch	958 bytes	Simon Georges
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Simon Georges CreditAttribution: Simon Georges commented 18 June 2012 at 08:02

Status:

Active

» Needs review

File	Size
commerce_1643996_prevent_payment_notice.patch	958 bytes

I'm proposing a patch that is working for me.

Comment #2

rszrama CreditAttribution: rszrama commented 18 June 2012 at 12:11

Looks like a perfect patch, Simon! What's happening is the AJAX refresh triggers a rebuild of the entire form, not just the parts that you're specifically replacing via the AJAX refresh callback. Naturally, some form values have been filled out, so $form_state['values'] has data, but the commerce_payment array is empty until the user actually puts data in there. This looks like it was just a bad if check to begin with, and your patch is the right solution.

Welcome to the committers log. : )