It would be nice to see the new Cookie Control Version 5 (the JS Library) integrated into this module. I will upload my patch to enable this in a while. A question though, is the library actually GPL?

CommentFileSizeAuthor
#11 cookiecontrol-5.1.diff72.53 KBreinier_post
#1 cookiecontrol_version5_1645562_1.patch60.95 KBnickbits
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nickbits’s picture

nickbits CreditAttribution: nickbits commented
FileSize
cookiecontrol_version5_1645562_1.patch60.95 KB

I have attached a patch to upgrade the module to use Cookie Control JS Version 5. This brings in additional control, you can now select information, implicit or explicit consent methods. See http://www.civicuk.com/cookie-law/cookie_configuration_v5 for information on the different methods in full.

Essentially there are the following modes:

  • Explicit - Informs the user the site is not using cookies and they are given the option to opt in.
  • Implicit - Informs the user the site is using cookies and they are given the option to opt out.
  • Information - Informs the user the site is using cookies and they are given no option to opt out.

I have also corrected a few other bugs such as the double paragraph tags that were showing in some parts of the rendered code.

NOTE: I have not fully tested the patch with all settings in different browsers, so please do not use on production sites, use only on a test site. If you find any issues, please submit a patch to correct.

Thanks,
Nick

cshedden’s picture

cshedden CreditAttribution: cshedden commented

Hi nickbits,

Good job on this.

Any idea when this is going to be rolled into a beta version?

I'm running Drupal on windows and don't have development setup to roll that patch into the code - unless someone can point me in the right direction - I'm not a git user.

Cheers

Colin

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Hi cshedden,

Good question. I don't know when it will be added into the development/beta snapshot, I don't have any privileges for this project, it is up to the maintainer to commit it.

You can get Git for windows ( http://msysgit.github.com/ ) and to apply a patch see the Drupal Docs ( http://drupal.org/patch/apply ).

Good luck,
Nick

budda’s picture

budda
Primary language English
Location Cheshire
CreditAttribution: budda commented

re: GPL / distribution
I've obtained permission to include the Cookie Control script as part of the Drupal module.

I never got any notification from CivicUK about the new version of the JS library so overlooked this, sorry!

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Excellent, and no problem. I only found out by accident. Hope the patch works!

zanonmark’s picture

zanonmark CreditAttribution: zanonmark commented

+1 for me too to upgrade the library to get "explicit consent",

thanks for this good module,

Marco

Tess Bakker’s picture

Tess Bakker
they/them
Primary language Dutch
CreditAttribution: Tess Bakker commented

Hi nickbits,

Against which version do I have to patch?

http://drupalcode.org/project/cookiecontrol.git

Patching against 1.x-dev (31 may) and version 1.5/1.4 fails.

Thanks,

Tessa

Homotechsual’s picture

Homotechsual CreditAttribution: Homotechsual commented

Has this been actioned yet?

nickbits’s picture

nickbits CreditAttribution: nickbits commented

Hi Tssa,

I would have used the dev release closest to June 18th. It still works for me. Can you post the exact steps you took to try and patch it.

Nick

nickbits’s picture

nickbits CreditAttribution: nickbits commented
Status: Active » Patch (to be ported)

Hi MJCO,

I have asked for it to be committed, I am not a maintainer, nor do I wish to be, hence I do not have the privileges to commit. Perhaps if you request to the module maintainer he will commit it.

Regards,
Nick

reinier_post’s picture

reinier_post CreditAttribution: reinier_post commented
FileSize
cookiecontrol-5.1.diff72.53 KB

Your patch is quite essential to our ability to use this module (as I understand it, opt-out is not good enough for Dutch law, so I need opt-in, your new 'explicit' mode).

It no longer applies 100% cleanly; while fixing it I thought I'd try 5.1 instead of 5.0.
The result is attached.

I have twiddled with the configuration options and they all appear to work; more thorough testing would be welcome.

budda’s picture

budda
Primary language English
Location Cheshire
CreditAttribution: budda commented
Assigned: Unassigned » budda
Status: Patch (to be ported) » Fixed

dev branch now contains suport for cookie Control 5.1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

BarisW’s picture

BarisW CreditAttribution: BarisW commented

@Reinier: you might want to check out http://drupal.org/project/ro_cookie_opt_in, which is opt-in based and offers logging as well.