Steps to reproduce:
Create two features, each with at least 2 variants of the same page.
Change one of the variants
Run drush fua -y
Run drush fl

Expectation: Nothing is overridden.

Reality: The features are marked as overridden.

Then, just to compound everything:
Run drush fra --force -y
Run drush fl
Pick one of the features that is STILL marked overridden
Run drush fd THAT_FEATURE

It will report that nothing is overridden.

Files: 
CommentFileSizeAuthor
#1 features-1647894-1.patch1.13 KBtim.plunkett

Comments

Status:Active» Needs review
StatusFileSize
new1.13 KB

When exporting page handlers, it assigns each pane a "new-*" ID.
The counter for that ID is statically cached, since only one is exported at a time.

However, when running features-list, it renders all at once, which never resets the counter.

In code:

Feature 1:
  Variant 1:
    new-1
    new-2
  Variant 2:
    new-1
    new-2
Feature 2:
  Variant 1:
    new-1
    new-2
  Variant 2:
    new-1
    new-2

Generated for comparison:

Feature 1:
  Variant 1:
    new-1
    new-2
  Variant 2:
    new-3
    new-4
Feature 2:
  Variant 1:
    new-5
    new-6
  Variant 2:
    new-7
    new-8

This resets that ID when appropriate.

Note, the second example in #1 with the sequential ids is wrong. The patch makes the generated code match the default code.

Version:7.x-1.x-dev» 6.x-1.x-dev
Status:Needs review» Patch (to be ported)

Wow, nice catch Tim, that must have been "fun" to debug. Committed and pushed to 7926e6c.

Also cross-referencing this with #1369246: Features incorrectly reporting panels as overridden. Pid counting changed. (which was one of the reasons for the UUID patch).

@mpotter, I'm a little confused. You've stated that the patch has been committed and that was June 20th. The currently release of Features was on July 25th. I still get the problem in D7.

My apologies it just dawned on me that I made this feature on one of my Aegir platforms that was made back in April and I'm installing it on my new platform which was made this week.

Very sorry for mucking up the Issue Queue. Thanks for the work!