The "error" class missing when the textfield is not valid [#1650674]

When the textfield does not validate, the field is not assigned the "error" class and is not highlighted.
I am using version 7.x-1.0+8-dev on drupal 7

I solved the issue by adding a line of code but I don't know if there is a better way
Added to line 222:

    // Add "error" class to non-valid field.
    $form_state["complete form"]["field_location"]["und"][0]["select_other_text_input"]['#attributes']['class'][0] .= " error"; 
  }

Comment	File	Size	Author
#2	1650674-error-class-on-text-input-3.patch	1.34 KB	mradcliffe
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 5 July 2012 at 13:14

Yes, for some reason it's not adding the class when form_set_error or form_error is called. This is usually automatic, but it's probably getting confused by the array parents.

Comment #2

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 8 September 2012 at 19:09

Status:

Active

» Needs review

File	Size
1650674-error-class-on-text-input-3.patch	1.34 KB

Here's a patch (combined, i have two commits ready). Let's see how badly it fails on PIFR (Can't run tests locally because MAMP/Simpletest seems to be borked).