Part of meta-issue #1518116: [meta] Make Core pass Coder Review
I'll do it this weekend. Assigning the issue to myself.
Thanks, @fotuzlab. Don't forget to claim the module on the meta issue, too.
Coder 8 did not work for me. So I used Drupal code sniffer.
Following are the two issues reported by DCS those I skipped.
Line 48 | ERROR | No key specified for array entry; first entry specifies key
Line 32 | ERROR | No key specified for array entry; first entry specifies key
Attached is the patch for rest of the coder fixes.
Thanks, @fotuzlab. Most of this looks pretty good. I'm going to postpone, however, pending resolution of #1539712: [policy, no patch] Coding standards for breaking function calls, function declarations, and language constructs across lines.
While you're waiting, there should be no DocBlock on inherited methods. See http://drupal.org/node/325974. These additions should be removed from the patch. Attached is the drupalcs output after your patch to take care of, too.
Thanks Travis. I'll go through the links.
Also the last two errors output by drupalcs are the ones I have mentioned in my last comment. I guess they are to be ignored.
btw, I came across this http://drupal.org/node/1649140 today morning. Assigning it to myself as it relates to this issue.
Can you document your reason for ignoring those drupalcs errors here?
Also, when linking to issues, use this format [#1649140] to automatically get this: #1649140: Clean up API docs for xmlrpc module. :)
We have the go ahead with all these issues again, see #1518116: [meta] Make Core pass Coder Review for more details
Drupal is a registered trademark of Dries Buytaert.