The operations links "edit", "delete", "enable/disable", "translate", "revert", "clone", etc in the rules and components overview pages don't have any classes, making them very hard to theme without javascript hacks.

I propose adding a simple class with the name of the operation to each link.

Files: 
CommentFileSizeAuthor
#3 pretty-rules-ui.jpg57.62 KBalexweber
#1 rules-operations-link-class-1655534-1.patch3.65 KBalexweber
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch rules-operations-link-class-1655534-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.65 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch rules-operations-link-class-1655534-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Simple patch attached to add classes to the operations links.

Assigned:Unassigned» klausi

@klausi: what do you think?

@alexweber: just out of curiosity, could you please post screenshots of the theming you did?

StatusFileSize
new57.62 KB

@mitchell: sure, screenshot attached! (It's using the Fubik admin theme)

@klausi: the patch is really minimal, I just added a class to each link so when can tell which one does what :) Adding styles like in the image using those links is entirely up to the admin theme.

@alexweber: thank you; it is really pretty!! :) I also created #1733362: Add icons for rule editing screen as a follow up.

> Adding styles [that use] those links is entirely up to the admin theme.
I think this approach is an improvement to the 6.x implementation. This way all Rules needs is to define CSS class names, and then the icons can fit it with their own specific focus / metaphor.

To support the default admin theme, Seven, perhaps we could collaborate with Iconizer or some other Libraries API - type - icon project.

@mitchell, awesome! Thanks for the support on this!

@klausi, can you consider this please?

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed, thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.