Ran into this bug when I have a filter set up with a different identifier, found out that the problem was with some code inside the date_views_filter_handler_simple where its not accounting for a different identifier.

CommentFileSizeAuthor
#1 identifier-fix-for-filter-remember-1659466-1.patch1.05 KBartkon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

artkon’s picture

artkon CreditAttribution: artkon commented
FileSize
identifier-fix-for-filter-remember-1659466-1.patch1.05 KB

Patch for 7.x-2.5

artkon’s picture

artkon CreditAttribution: artkon commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, identifier-fix-for-filter-remember-1659466-1.patch, failed testing.

artkon’s picture

artkon CreditAttribution: artkon commented
Status: Needs work » Needs review

#1: identifier-fix-for-filter-remember-1659466-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, identifier-fix-for-filter-remember-1659466-1.patch, failed testing.

artkon’s picture

artkon CreditAttribution: artkon commented
Status: Needs work » Needs review

Can someone review this issue, it looks like simpletest is failing regardless of the patch, see issue here http://drupal.org/node/1662840

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented

#1: identifier-fix-for-filter-remember-1659466-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, identifier-fix-for-filter-remember-1659466-1.patch, failed testing.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Version: 7.x-2.5 » 7.x-2.x-dev
Status: Needs work » Needs review

I re-tested that because I submitted an issue and my test passed, so I assumed tests had been fixed in the mean time. After taking a closer look the problem looks to be that you've set the version to 7.x-2.5, but that's a tag and releases need to be against the branch.

Code change looks sensible, although it's not a feature I've come across so I wouldn't feel comfortable setting to RTBC

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented

#1: identifier-fix-for-filter-remember-1659466-1.patch queued for re-testing.

stred’s picture

stred CreditAttribution: stred commented

good to know !!!
same on 6.x-2.9

plachance’s picture

plachance CreditAttribution: plachance commented

I have this bug too with Date 7.x-2.6. I've applied the patch manually and it doesn't seem to work. Plus, the patch would only work if the remember option is set. The value would still be lost between postbacks, unlike all other Views' filters.

recrit’s picture

recrit CreditAttribution: recrit commented
Status: Needs review » Reviewed & tested by the community

this patch worked for me on an exposed date filter set to be remembered.
@plachance: the goal of the patch is to fix the views session for when the filter is set to be remembered. What specifically didn't work for you?

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

#1732650: Make "Remember the last selection" work was marked as a duplicate of this thread.

csilfverduk’s picture

csilfverduk CreditAttribution: csilfverduk commented

I can confirm @recrit on this- the patch is working for us.

cafuego’s picture

cafuego CreditAttribution: cafuego commented
Status: Reviewed & tested by the community » Fixed

Applied to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.