Commerce Order Types

Welcome,

we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hi,

Please wait for manual review. Meanwhile you can fix these errors from automated review : http://ventral.org/pareview/httpgitdrupalorgsandboxmanatwo1341264git-7x-1x

Regards,
Chintan Vyas.

Manual Review :

1. In commerce_order_types.install on line 11, No need to define $schema = array(); but lot of people prefer to write it for more readability. So its up to you :)
2. In commerce_order_types.install file, end file with 1 blank line.
3. In commerce_order_types.install file, May be you can write more description of commerce_order_types_schema() function. What that schema is for and what kind of data it stores.
4. In commerce_order_types.module file, end file with 1 blank line.

Regards,
Chintan Vyas.

I haven't tried this or read the code myself, but #1418322: Questions on how to use order type leads me to mark this as rtbc.

#5: 1 and 3 seem like worthwhile improvements. Also the snippet below could be improved. chintan.vyas, could you please file an issue in the project for these changes?

  field_create_instance(array(
                              'field_name' => 'commerce_payout_pay_date',
                              'entity_type' => 'commerce_order',
                              'bundle' => 'commerce_payout'));

  commerce_order_configure_order_type('commerce_payout');

@mitchell : Created issue in project https://drupal.org/node/1670874
Also couldn't get you how the snippet you posted can be improved? Can you explain more so I can understand :)

It's just odd formatting is all. The whole two spaces thing.

Try to use the [#issue number thing] too. Thanks for creating the issue. Want to write the patch as well?

There is still a master branch, make sure to remove it. See also step 6 and 7 in http://drupal.org/node/1127732

manual review:

1. "'access arguments' => array('administer order types'),": where is that permission defined?
2. "// Not allowed to delete any code provided line item type.": line item type?
3. commerce_order_types_order_type_form_validate(): why is that needed? The machine name form element should already validate the uniqueness for you?

The permission issue is not a security blocker, because user_access() will return FALSE anyway for non-existing permissions. You module is only usable for user 1 right now.

Thanks for your contribution, manatwo! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.