Attached patch adding tests for the product node inline form UI.

CommentFileSizeAuthor
ief_testing.patch5.33 KBitamar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

Status: Needs work » Needs review

Work in progress, test currently only includes testing the commerce product <-> node relation. Setting to needs review, for the testbot to trigger.

joachim’s picture

Status: Needs review » Postponed
+++ b/inline_entity_form.test
@@ -0,0 +1,120 @@
+class InlineEntityFormTestCase extends CommerceBaseTestCase {

The base test for this module shouldn't require Commerce.

We should probably wait till #1658056: Add node integration gets in and use that as the base test, with a second class for Commerce integration.

bojanz’s picture

I'm fine with having a test that requires Commerce, we should just have one that doesn't as well.
I've yet to review these tests, will do so later.

joachim’s picture

Sure, but then the test class that requires Commerce probably shouldn't be called InlineEntityFormTestCase ...

bojanz’s picture

Yep, that's true.

amitaibu’s picture

Status: Postponed » Needs work

Correct status

amitaibu’s picture

Issue summary: View changes

Updated issue summary.