As I could notice there are some form elements on the settings form that are assumed to be conditional : some textfields need to be displayed only if appropriate value in radiobutton is selected.
I think it would be better if we could make this form AJAXified.

I will provide a patch soon.

CommentFileSizeAuthor
#2 make_settings_form_ajaxified-1663004-1.patch6.49 KBPatchRanger
#1 make_settings_form_ajaxified-1663004-0.patch5.88 KBPatchRanger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Status: Active » Needs review
FileSize
make_settings_form_ajaxified-1663004-0.patch5.88 KB

Done.
I've also made some tuning to pass Coder tests.
Please review.

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
FileSize
make_settings_form_ajaxified-1663004-1.patch6.49 KB

Inspired by the idea of making this form truly AJAXified I have added conditional appearing and disappearing of the whole fieldset of the settings. This fieldset is listening to "Store value in the database" checkbox.
Please review this one.