Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Sub-issue of #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core
Inline with the CSS cleanup efforts of the HTML5 initiative, using CSSLint at http://csslint.net provides a quick way to code-sniff our css and tweak styles.
- Copy and paste the the stylesheet(s) below into the css lint tool at http://csslint.net and test.
- Fix any warnings or errors the tool finds.
- Patch Drupal 8 locally and make sure the css changes have not broken anything visually.
- Create patch and upload for the testbot.
Files: modules/poll/poll.css (and poll-rtl.css)
Comment | File | Size | Author |
---|---|---|---|
#9 | 1663146-9_post-lint-poll-css.patch | 2.81 KB | adammalone |
#7 | 1663146-7.patch | 630 bytes | rpayanm |
#5 | 1663146_post-lint-poll-css.patch | 0 bytes | adammalone |
#2 | 1663146-2-cleanup-poll-css.patch | 774 bytes | Manuel Garcia |
Comments
Comment #1
RobLoachhttps://gist.github.com/3006391#L5345
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia commentedThe ids in admin css are handed over by the forms so I'm guessing thats ok to keep.
Cleaned up the rest.
Comment #3
alexpottPoll is no longer part of core
Comment #4
adammaloneThis will need rerolling to apply against poll module now it's out of core.
Also ran into this whilst using CSSLint:
width can't be used with display: inline.
for
Comment #5
adammaloneCSS Lint passes with this plus we can get rid of some unnecessary files in the repo. This should pass tests etc but I'll post here anyway before committing.
Comment #7
rpayanmrerolling...
Comment #9
adammaloneawks, 0B patch file...
Comment #11
adammaloneRespinning tests after the watchdog fix in #2331515: Allow to show the poll question in the vote/result templates
Comment #14
adammalone