Sub-issue of #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core

Inline with the CSS cleanup efforts of the HTML5 initiative, using CSSLint at http://csslint.net provides a quick way to code-sniff our css and tweak styles.

  1. Copy and paste the the stylesheet(s) below into the css lint tool at http://csslint.net and test.
  2. Fix any warnings or errors the tool finds.
  3. Patch Drupal 8 locally and make sure the css changes have not broken anything visually.
  4. Create patch and upload for the testbot.

Files: modules/poll/poll.css (and poll-rtl.css)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

Manuel Garcia’s picture

Status: Active » Needs review
FileSize
774 bytes

The ids in admin css are handed over by the forms so I'm guessing thats ok to keep.

Cleaned up the rest.

alexpott’s picture

Project: Drupal core » Poll
Version: 8.x-dev » 8.x-1.x-dev
Component: poll.module » Code

Poll is no longer part of core

adammalone’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

This will need rerolling to apply against poll module now it's out of core.

Also ran into this whilst using CSSLint:
width can't be used with display: inline.
for

.node-form #poll-choice-table .form-text {
  display: inline;
  width: auto;
}
adammalone’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
0 bytes

CSS Lint passes with this plus we can get rid of some unnecessary files in the repo. This should pass tests etc but I'll post here anyway before committing.

Status: Needs review » Needs work

The last submitted patch, 5: 1663146_post-lint-poll-css.patch, failed testing.

rpayanm’s picture

Status: Needs work » Needs review
FileSize
630 bytes

rerolling...

Status: Needs review » Needs work

The last submitted patch, 7: 1663146-7.patch, failed testing.

adammalone’s picture

Status: Needs work » Needs review
FileSize
2.81 KB

awks, 0B patch file...

Status: Needs review » Needs work

The last submitted patch, 9: 1663146-9_post-lint-poll-css.patch, failed testing.

adammalone’s picture

Status: Needs work » Needs review

  • typhonius committed 9fb78f6 on 8.x-1.x
    Issue #1663146 by typhonius, rpayanm, Manuel Garcia | ZenDoodles: Clean...
adammalone’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.