Audit the code for FacetapiFacet::getSettings() calls and replace with FacetapiAdapter::getFacetSettings*() [#1665658]

Settings used to be retrieved from FacetapiFacet::getSettings(), however for better caching most of the logic was moved to the FacetapiAdapter::getFacetSettings*() methods, while keeping FacetapiFacet::getSettings() as a convenience method. We should audit the code for FacetapiFacet::getSettings() and replace with FacetapiAdapter::getFacetSettings*() methods as necessary, as it would eliminate some extra logic and a method call per instance.

Comment	File	Size	Author
#2	get-settings-audit-1665658-2.patch	5.08 KB	cpliakas
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

cpliakas CreditAttribution: cpliakas commented 29 June 2012 at 16:02

A quick grep shows the following instances.

./facetapi.admin.inc:391: $facet_settings = $adapter->getFacet($facet)->getSettings($realm);
./facetapi.admin.inc:392: $global_settings = $adapter->getFacet($facet)->getSettings();
./facetapi.admin.inc:762: $facet_settings = $adapter->getFacet($facet)->getSettings($realm);
./facetapi.admin.inc:768: $global_settings = $adapter->getFacet($facet)->getSettings();
./facetapi.admin.inc:816: $settings = $adapter->getFacet($facet)->getSettings($realm);
./facetapi.module:368: $settings = $adapter->getFacet($facet)->getSettings();
./facetapi.module:1107: $settings = $adapter->getFacet($facet)->getSettings($realm);
./plugins/facetapi/adapter.inc:591: $settings = $this->getFacet($facet)->getSettings();