Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Thank you very much for this handy module.
While playing around with it I came across this:
Important: C2DM has been officially deprecated as of June 26, 2012. At that time C2DM stopped accepting new users and quota requests. C2DM has been replaced by Google Cloud Messaging for Android (GCM). The C2DM service will continue to be maintained in the short term, but developers must use GCM for new development. We also encourage developers to move existing C2DM applications to GCM to take advantage of GCM features. See the C2DM-to-GCM Migration document for more information.
Thus I decided to add GCM support to the module.
While doing so I thought it could also be handy to have a way to unregister tokens manually by using REST - thus this I added that too.
And finally I thought it would be nice to see the Structure of the necessary REST calls and added a README.txt
The only changes left in the patch is the removal of trailing whitespaces (does my editor automatically).
| Comment | File | Size | Author |
|---|---|---|---|
| push_notifications-added-GCM-support-since-C2DM-is-deprecated.patch | 14.99 KB | das-peter |
Comments
Comment #1
shushu CreditAttribution: shushu commentedHi,
http://drupal.org/project/gcm is gcm-only module, but I try to keep up with updating it and make it fully featured for Android push notification.
The way I decided to handle unregistration is on the server side only (for now), using Rules. In case of an error an event is being called to handle removal of the problematic registration ID. Using Rules I keep the flexibility of the module as flexible as possible.
Regards,
Shushu
Comment #2
das-peter CreditAttribution: das-peter commentedShushu, thanks for the feedback. The idea of integrating with rules is very nice.
Was there a reason why you started a new project?
As a Module-User I would like to have a module that aims to cover iPhone and Android.
However, as developer I understand that it's sometimes difficult to cover all the needs.
But what about joining forces on this module? I think the chances are good to create a module that covers both devices and is still maintainable for the devs. And it would reduce the module fragmentation :)
I'm not the maintainer of this module nor do I have any commit permissions but if you agree with joining forces I'll try to get feedback of haagendazs asap.
Comment #3
shushu CreditAttribution: shushu commentedHi Peter,
I talked with Daniel Hanold before starting to develop the module, and actually used it as a basis.
I hoped to work with him on it, but he was too busy to find time for it, so I decided to move forward myself. I kept updating him on my effort during this time.
I understand the need to find proper solution for both iOS and Android, but since my projects are Android-only for now, I as well can't find time to spare on additional tasks out of my focus. I hope some day to make it for iOS, but I don't want to wait for it.
I am open for new ideas on how to share forces and move this module together.
Regards,
Shushu
Comment #4
haagendazs CreditAttribution: haagendazs commenteddas-peter / shushu : My apologies for not seeing this message earlier, I forgot that drupal.org doesn't automatically send email updates to the module creators ;)
shushu: From the emails you had sent me, it wasn't quite obvious to me that you wanted to create a whole new project for Google Cloud Messaging, especially since the current module is already so close.
I reviewed das-peter's patch, which looks fantastic. I love that you even stuck to my naming-conventions for constants. Really great! I added the patch and made a few modifications:
I added a new tag (7.x-1.x-alpha2), should be up on here soon: http://drupalcode.org/project/push_notifications.git/commit/dad51c263bbd...
Comment #5
das-peter CreditAttribution: das-peter commented@haagendazs: Awesome! Thank you for committing the patch :)
And sorry about the missing update hook, I totally forgot that I adjusted that field manually...
Just in case you don't know the page for configure the E-mail notifications: http://drupal.org/project/issues/subscribe-mail/push_notifications