Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
I am trying to fiddle my way through the heap of commerce modules needed to do a simple, standard commerce site.
Commerce_Email sometimes works fine, even somehow as expected.
Yet there's an issue that I do not fully understand. The line items created for outgoing email are seperated into "products" and "not products", with the later getting a default quantity of "1", no matter what the actual order says. See code line 128 in "commerce_email.module":
array('data' => 1, 'style' => array('text-align: left;')),
I have replaced this by
array('data' => intval( $line_item_wrapper->quantity->value()), 'style' => array('text-align: left;')),
resulting in non-standard products being listed correctly in outgoing mail (example PRICETABLE products, which always got a "1 quantity" with the original code).
Could you please be so kind and approve or decline this change?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | commerce_email-quantity-of-custom-line-items-1666358-2.patch | 822 bytes | haggins |
Comments
Comment #1
malbrecht CreditAttribution: malbrecht commentedI am not sure what I have done wrong to not get any response. Is my hint not considered helpful in order to improve this module?
Comment #2
haggins CreditAttribution: haggins commentedMaybe too less people are using custom line-items? Whatever, here's the patch.
I didn't include
intval()as this would format the quantity of custom line items in another way than default line litems.Comment #3
rszrama CreditAttribution: rszrama at Centarro commentedReviewing, seems to check out.
Comment #5
rszrama CreditAttribution: rszrama at Centarro commented