Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
South Africa has Provinces, not States. Please can you change this.
Thank you
Comment | File | Size | Author |
---|---|---|---|
#7 | za_provinces-1669620-3.patch | 2.3 KB | RStrydom |
#2 | za_provinces-1669620-2.patch | 3.29 KB | malberts |
#1 | za_provinces-1669620-1.patch | 2.92 KB | malberts |
Comments
Comment #1
malberts CreditAttribution: malberts commented- Added a list of South African provinces as per ISO 3166-2:ZA.
- Changed the label "States" to "Provinces" and moved it to be the last item in the form.
As stated in #1219658: GB Specific Changes, this type of solution can become hard to maintain but we need this to support South African provinces.
Comment #2
malberts CreditAttribution: malberts commentedI needed to follow the UK example more closely, so here's a new patch that does not put the locality fields directly next to each other.
Comment #3
hmartens CreditAttribution: hmartens commentedThank you very much for the help! I really appreciate it!
Comment #4
rszrama CreditAttribution: rszrama commentedComment #5
niki v CreditAttribution: niki v commentedPatch works correctly, thanks!
Comment #6
niki v CreditAttribution: niki v commentedComment #7
RStrydom CreditAttribution: RStrydom commentedUpdated the patch from #2 to be compatible with the latest version.
Also added
'#render_option_value' => TRUE,
to the Provinces as we work with the full name and not the abbreviationsComment #8
foxtrotcharlie CreditAttribution: foxtrotcharlie commentedTested this, and it works for me on addressfield 7.x-1.0-beta5. Thanks :-)
Comment #9
bojanz CreditAttribution: bojanz commentedFixed two wrong ISO codes:
and committed the patch.
Comment #11
bojanz CreditAttribution: bojanz commentedComment #12
bojanz CreditAttribution: bojanz commentedHm, Google's dataset says that the states aren't actually used for mailing in South Africa, and
http://www.postoffice.co.za/questions/postofficequestions.html#Correct doesn't mention the state either.
Therefore, we should actually remove the state field?
Comment #13
bojanz CreditAttribution: bojanz commentedBased on the official post office quote:
I have reverted the patch.
It shows that the correct tweaks to apply are
- Hide the administrative area field- Add the suburb (dependent_locality) field.
- Make sure the ordering is correct.
EDIT: A recent commit has resulted in the administrative area being correctly hidden for South Africa.
Comment #15
hmartens CreditAttribution: hmartens commentedThanks Bojan for your work on this. It's much appreciated!
Comment #16
bojanz CreditAttribution: bojanz commentedThe suburb field now shows up, the ordering is correct.