Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The following patch fixes the display of the tab "CSSS Compression" and problem with db_query() and db_fetch_array()
Comment | File | Size | Author |
---|---|---|---|
#1 | advagg-fix-display-css-compression-admin-tab-bundler-and-advagg-admin.patch | 2.71 KB | facine |
advagg-fix-display-css-compression-admin-tab-and-bundler.patch | 2.15 KB | facine | |
Comments
Comment #1
facine CreditAttribution: facine commentedAdded fix in advagg_admin_batch_rebuild.
Comment #2
Prague man CreditAttribution: Prague man commentedWHYYYYY mikeytown2!
Why are these patches are not applied to the module?
Comment #3
realityloopComment #4
shunting CreditAttribution: shunting commentedApplies against the dev version, works beautifully. Thanks.
Comment #5
wizonesolutionsJS version here: #1669952: [META] AdvAgg D7 - JS Compression not working
Comment #6
wizonesolutionsPrague man: mikeytown2 doesn't have much need for the 7.x version yet. He said via Twitter that he would in a couple months. I imagine he will go through and commit patches then.
If I can get paid to work on this module, then I will apply for co-maintainership and commit the patches also if they make the module work the same way it did in Drupal 6 (with necessary adjustments for Drupal 7).
No guarantees though.
Comment #7
markhalliwell@Prague man: Mikey isn't working on the 7.x-1.x branch, I am. I apologize for the tardy responses. This module has been on the back burner for a while.
@facine: thanks for the patches, I'll review them once #1705352: [META] AdvAgg D7 - Aggregates Not Building has been implemented and fixed, which is a little higher on the priority list. More than likely due to a lot of API changes between D6 and D7 (in regards to how the CSS and JS data arrays are structured), these patches might need to be adjusted slightly after that issue is fixed.
@wizonesolutions: I would appreciate any help regardless. I am certainly not getting paid for this which is why modules often have dry spells.
I'm renaming this issue to become the meta issue for #1171546: AdvAgg - D7 Port/Re-write and placing it on the issue summary of that issue. This will need to be fixed before a stable release can be made.
Comment #8
markhalliwellComment #9
markhalliwellTitle ping pong
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedFixed in the latest 7.x-2.x #1171546-105: AdvAgg - D7 Port/Re-write