Drush does not respect the interactive switch. [#1673814]

When trying to run commands in interactive mode, all interactive prompts are either aborted or assumes yes.

Example from documentation:
-ia, --interactive Force interactive mode for commands run on multiple targets (e.g. `drush @site1,@site2 cc --ia`).

My Test:

miked@server1:/home/drupal$ drush @sites cc --ia
.home.drupal#site1             >> Enter a number to choose which cache to clear.
.home.drupal#site1             >>  [0]  :  Cancel
.home.drupal#site1             >>  [1]  :  all
.home.drupal#site1             >>  [2]  :  drush
.home.drupal#site1             >>  [3]  :  theme-registry
.home.drupal#site1             >>  [4]  :  menu
.home.drupal#site1             >>  [5]  :  css-js
.home.drupal#site1             >>  [6]  :  block
.home.drupal#site1             >>  [7]  :  module-list
.home.drupal#site1             >>  [8]  :  theme-list
.home.drupal#site1             >> Cancelled
.home.drupal#site2             >> Enter a number to choose which cache to clear.
.home.drupal#site2             >>  [0]   :  Cancel
.home.drupal#site2             >>  [1]   :  all
.home.drupal#site2             >>  [2]   :  drush
.home.drupal#site2             >>  [3]   :  theme-registry
.home.drupal#site2             >>  [4]   :  menu
.home.drupal#site2             >>  [5]   :  css-js
.home.drupal#site2             >>  [6]   :  block
.home.drupal#site2             >>  [7]   :  module-list
.home.drupal#site2             >>  [8]   :  theme-list
.home.drupal#site2             >>  [9]   :  nodeaccess
.home.drupal#site2             >>  [10]  :  views
.home.drupal#site2             >> Cancelled

I would expect to be able to select the options interactively. I mangled a few sites running pm-update with this switch. Drush assumed 'yes' and upgraded everything instead of showing me available updates and allowing me to choose wether to proceed or not.

Comments

Comment #1

mgifford

he/him

English

CreditAttribution: mgifford commented 11 July 2012 at 02:49

Yup, tried this on 3 different machines with drush version 5.4.

Comment #2

greg.1.anderson CreditAttribution: greg.1.anderson commented 11 July 2012 at 04:42

I think that the backend invoke concurrency patch must have broken interactive mode with multiple targets.

Comment #3

mducharme CreditAttribution: mducharme commented 16 July 2012 at 15:51

Is there a process to get this fixed? Can you provide a reference to the patch that may have broken this so we can get some movement on this?

Comment #4

greg.1.anderson CreditAttribution: greg.1.anderson commented 16 July 2012 at 16:22

I think that this can be fixed in function drush_preflight_command_dispatch() via something similar to:

   if (drush_get_option('pipe') || drush_get_option('interactive')) {
      $backend_options['interactive'] = TRUE;
    }

n.b. current code only checks 'pipe', does not check interactive. Looks like this is unrelated to the backend invoke rewrite that happened; you could use git bisect to find the commit where it broke, if you wish.

Comment #5

mducharme CreditAttribution: mducharme commented 16 July 2012 at 20:58

Upon further inspection, I don't think it's a problem with the backend not receiving the switch. I tested this by adding the following to my drushrc.php file (which is basically the result of what you suggested):

$options['interactive'] = TRUE;

This is correctly picked up but I still get no interactive prompts when running the original command.

Comment #6

greg.1.anderson CreditAttribution: greg.1.anderson commented 16 July 2012 at 21:20

$options['interactive'] is different than setting $backend_options['interactive'] = TRUE;, so #5 is different than the advice in #4. $backend_options control how a specific call to backend invoke should be processed; you cannot set backend options from a drushrc.php file.