In advagg_js_compress.module's advagg_js_compress_advagg_files_table function the variable is assigned 'js' rather than tested against 'js'.

Is: 

  if ($row['filetype'] = 'js' && $checksum != $row['checksum']) {

Should be: 

  if ($row['filetype'] == 'js' && $checksum != $row['checksum']) {
CommentFileSizeAuthor
#4 advagg-1674262-4-fix-js-compression-issue.patch667 bytesmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

soulfroys’s picture

soulfroys
Primary language Portuguese, Brazil
CreditAttribution: soulfroys commented
Component: JS Compression » Code
Status: Active » Fixed
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Fixed » Active

This is still an issue in the latest code in the repo. Please don't mark an issue as fixed unless it's actually been fixed in the repo
http://drupalcode.org/project/advagg.git/blob/934e4ac6ab0528082e858fc5e0...

soulfroys’s picture

soulfroys
Primary language Portuguese, Brazil
CreditAttribution: soulfroys commented

My bad... I forgot that I'm using the stable version.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Issue summary: View changes
Status: Active » Fixed
FileSize
advagg-1674262-4-fix-js-compression-issue.patch667 bytes

Committed the fix

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.