Problem

  • image_style_add_form() is a completely separate form, duplicating the entire code of image_style_form().

Goal

  • Apply common patterns.

Proposed solution

  1. Remove image_style_add_form().
  2. Change the menu/router item to point to a new image_style_add_page() page callback function, which creates an empty $style thingie and passes that to image_style_form().
  3. Ensure that page titles are correct.

Related issues

Comments

claudiu.cristea’s picture

Status: Active » Closed (duplicate)

This is fixed now by implementing \Drupal\image\Form\ImageStyleFormBase that is extended by ImageStyleAddForm and ImageStyleEditForm. Closing as duplicate.