find a solution for the #1672436: Move error message on checkout process Commerce Kickstart issue

On the checkout, the error message needed to be move in the fieldset area and not before as Drupal used to do it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vasike’s picture

Status: Active » Needs review
FileSize
779 bytes

here is patch for this feature

rszrama’s picture

Can I get a quick screenshot of the difference we're going for? I'm not sure the initial report makes a lot of sense, and I don't know if we want to go moving this in a minor version update since there may be sites and themes that depend on the current placement.

vasike’s picture

FileSize
38.85 KB

sorry about the quality (zoom).

bojanz’s picture

That's the "after" picture.
The "before" picture is this one: http://drupal.org/files/Capture%20d%E2%80%99%C3%A9cran%202012-07-05%20%C...

rszrama’s picture

Yeah, I saw that one in the linked thread. I'm still interested in feedback on potential drawbacks, though, since themes very well may have been constructed around the current ordering. Whaddya think?

bojanz’s picture

I'd guess that most just keep the current slightly-broken behavior, but I have no hard data.

(Btw, I've added the patch to Kickstart v2)

bojanz’s picture

Issue tags: +kickstart blocker

Tagging.

rszrama’s picture

Status: Needs review » Fixed

Overwhelming community consensus says "DO IT!"

https://twitter.com/ryanszrama/status/256224021744582656

Committed. ; )

Automatically closed -- issue fixed for 2 weeks with no activity.