Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem
- In edge-cases, error/exception assertions may be triggered and attempted to be inserted when the child site (under test) has not been set up yet.
Comment | File | Size | Author |
---|---|---|---|
#14 | drupal7-test_connection-1679570-14.patch | 2.22 KB | mgifford |
#7 | drupal7-test_connection-1679570-7.patch | 2.21 KB | lucascaro |
drupal8.test-connection.0.patch | 2.17 KB | sun | |
Comments
Comment #1
lucascaro CreditAttribution: lucascaro commentedseems legit
Comment #2
sunI guess you forgot to change the status? ;)
Comment #3
lucascaro CreditAttribution: lucascaro commentedindeed!
Comment #4
sundrupal8.test-connection.0.patch queued for re-testing.
Comment #5
sundrupal8.test-connection.0.patch queued for re-testing.
Comment #6
catchThis looks fine, just a helper and then actually using the same logic everywhere. Committed/pushed to 8.x, moving to 7.x for backport.
Comment #7
lucascaro CreditAttribution: lucascaro commentedHere's a direct port for D7
Comment #8
sunThanks for the backport! Looks ready to go for me.
However, not marking as RTBC yet, since I want to prevent potential commit conflicts with #1563620: All unit tests blow up with a fatal error
Comment #9
sunComment #10
mgifford7: drupal7-test_connection-1679570-7.patch queued for re-testing.
Comment #11
mgiffordWell, #1563620: All unit tests blow up with a fatal error is in, so should be RTBC now if there are no conflicts, right?
Comment #12
sunYes, I think it would be helpful to backport this, as it syncs part of the functional code.
However, the backport patch contains an phpDoc indentation error:
Comment #13
mgiffordSorry. I looked but still don't see the phpDoc indentation. Other than that though you'd see this as RTBC?
Comment #14
mgiffordTotally missed that space @sun. Had to get @mparker17 to point it out to me.
Think this gets it.
Comment #15
sunThanks!
Comment #18
mgiffordbad bot.
Comment #21
dcam CreditAttribution: dcam commentedComment #24
dcam CreditAttribution: dcam commentedComment #27
dcam CreditAttribution: dcam commentedComment #30
dcam CreditAttribution: dcam commentedComment #33
dcam CreditAttribution: dcam commentedComment #36
dcam CreditAttribution: dcam commentedComment #39
dcam CreditAttribution: dcam commentedComment #40
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!