Use standard rules token evaluation [#1682730]

The module runs it's own token evaluation instead of calling the standard RulesTokenEvaluator class.

I think we should call evaluate on whatever is set for $element->settings['variable:process'].

I noticed this problem after applying this a pending rules patch. The patch works for everything except the variable email texts. Calling evalute on the RulesTokenEvaluator solved the problem.

Comment	File	Size	Author
	0001-use-standard-rules-token-evaluation.patch	3.55 KB	pluess

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

guillaumev CreditAttribution: guillaumev commented 31 July 2012 at 08:06

Status:

Needs review

» Fixed

Thank you, I just committed this.

Comment #2

14 August 2012 at 08:11

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #3

C-Logemann

German

Frankfurt/M, Germany

CreditAttribution: C-Logemann commented 27 August 2012 at 19:24

This change looks good because of more common compatibility but it causes also some problems in other modules.
#1759140: Token API change in dev needs documentation and maybe an own branch

Comment #4

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

CreditAttribution: xurizaemon commented 7 October 2013 at 22:07

Status:

Closed (fixed)

» Active

I found with this fix applied that tokens weren't replacing, because isset($element->settings['variable:process']) was not true.

Using with a rule that contained actions to send Commerce Email and a custom email after that. I can't see where in Variable Email, Variable or Commerce Email that setting is set - is it version specific?

Added a comment at #1759140-11: Token API change in dev needs documentation and maybe an own branch with more details. This is closed and committed but may need to be reviewed as part of that issue.