Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options: 

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: locale/tests/locale_test.js, locale/locale.admin.js, locale/locale.datepicker.js

CommentFileSizeAuthor
#3 core-jshint-locale-1684852-3.patch1.21 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Active » Closed (works as designed)
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Closed (works as designed) » Needs work

New JSHint config #1995996: Update JSHint configuration.

core/modules/locale/locale.bulk.js: line 15, col 16, '$file' is defined but never used.

core/modules/locale/locale.admin.js: line 49, col 15, 'effect' is defined but never used.
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs work » Needs review
FileSize
core-jshint-locale-1684852-3.patch1.21 KB
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 12d1760 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.