API page: http://api.drupal.org/api/drupal/modules%21taxonomy%21taxonomy.module/fu...

Enter a descriptive title (above) relating to taxonomy_term_load, then describe the problem you have found:

If $tid not found, FALSE is returned. NULL would be also assumable.

Files: 
CommentFileSizeAuthor
#10 taxonomy_term_load-does-not-1689426-10.patch526 bytesmjonesdinero
PASSED: [[SimpleTest]]: [MySQL] 39,249 pass(es).
[ View ]
#6 taxonomy_term_load-does-not-1689426-6.patch582 bytesmjonesdinero
PASSED: [[SimpleTest]]: [MySQL] 37,293 pass(es).
[ View ]
#4 taxonomy_term_load-does-not-1689426-4.patch578 bytesmjonesdinero
PASSED: [[SimpleTest]]: [MySQL] 37,297 pass(es).
[ View ]
#2 taxonomy_term_load-does-not-1689426-2.patch514 bytesmjonesdinero
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch taxonomy_term_load-does-not-1689426-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
added_Return_message1.patch539 bytesronan.orb
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in added_Return_message1.patch.
[ View ]

Comments

Title:Return on failure missingtaxonomy_term_load() does not document return value on failure
Status:Active» Needs work
Issue tags:+Novice, +needs backport to D7

Thanks for the patch! See http://drupal.org/node/1689394#comment-6244396 for a note on patch formatting.

So this patch needs to be rerolled using Git, and also:
- Line wrapping -- move the added text up to the previous line, and wrap at 80 characters.
- Add "the" to "FALSE if *the* term was not found.".

Status:Needs work» Needs review
StatusFileSize
new514 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch taxonomy_term_load-does-not-1689426-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

re roll the patch..

Status:Needs review» Needs work

The last submitted patch, taxonomy_term_load-does-not-1689426-2.patch, failed testing.

Assigned:Unassigned» mjonesdinero
Status:Needs work» Needs review
StatusFileSize
new578 bytes
PASSED: [[SimpleTest]]: [MySQL] 37,297 pass(es).
[ View ]

sorry about the last patch submitted it was for d7 i thought it is for d7 but also in d8..

attach is the patch now for d8.

Status:Needs review» Needs work

Thanks!

This line is missing a space:

+ *   A taxonomy term entity. Results are statically cached.FALSE if the term

And maybe it would be better to say "... term entity, or FALSE if the term ..." rather than putting that at the end?

StatusFileSize
new582 bytes
PASSED: [[SimpleTest]]: [MySQL] 37,293 pass(es).
[ View ]

okie re-rolled the patch, git pull first for the update on the patch commited.

attach is the updated patch now..

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Looks good, thanks! I'll get it committed shortly.

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed to 8.x. The patch doesn't apply to 7.x, so we need a reroll.

Status:Patch (to be ported)» Needs review
StatusFileSize
new526 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,249 pass(es).
[ View ]

re-rolled the patch for D7

Status:Needs review» Reviewed & tested by the community

Thanks! I'll get this committed soon.

Status:Reviewed & tested by the community» Fixed

Committed to 7.x now too. Thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.