I've just noticed there are 3 places in this module which hard code the time limit to 240 seconds.

Whilest I agree that, in theory, you wouldn't want a request taking much longer than this, I think this is something which should really be left up to the site administrators.

I have just deployed a large site onto a small VM for testing and, even though drush has max_execution_time set to inifinite, I started getting 240s timeouts, which confused me as my php.ini was set to 120s.

Would it be possible to not do this or have it exposed as a setting? Maybe have a "hidden" and optional setting in $conf which you can specify in settings.php and the set time limit calls only use it if its set?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

  • mikeytown2 committed a53b965 on 6.x-1.x
    Issue #1689464 by mikeytown2: Allow for the set_time_limit() calls to be...
mikeytown2’s picture

Component: CSS Compression » Code
Issue summary: View changes
Status: Active » Fixed
FileSize
1.92 KB

new variable called 'advagg_set_time_limit'. default is 240 seconds.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.