I've just noticed there are 3 places in this module which hard code the time limit to 240 seconds.
Whilest I agree that, in theory, you wouldn't want a request taking much longer than this, I think this is something which should really be left up to the site administrators.
I have just deployed a large site onto a small VM for testing and, even though drush has max_execution_time
set to inifinite, I started getting 240s timeouts, which confused me as my php.ini was set to 120s.
Would it be possible to not do this or have it exposed as a setting? Maybe have a "hidden" and optional setting in $conf which you can specify in settings.php and the set time limit calls only use it if its set?
Comment | File | Size | Author |
---|---|---|---|
#2 | advagg-1689464-1-set-time-limit.patch | 1.92 KB | mikeytown2 |
Comments
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentednew variable called 'advagg_set_time_limit'. default is 240 seconds.