Hi,

We need to integrate a payment platform (no drupal commerce) for subscriptions.

This contrib module only deals with payment module.

It add some payment data to subs type entities and provide an embeddable payment form.
Note that it is integrate by the contrib module subs form.

As for other both issues (subs form and subs roles), still needs works and reviews.

Thanks a lot for reviewing if you are interested.

Sorry but I know that a more generic bridge should be appreciate (as using it with drupal commerce or other contrib module such as pay) but don't have time deals with it.

CommentFileSizeAuthor
#15 subs-subs_payment_payment-1691476-13.patch48.05 KBchaby
#13 subs-subs_payment_payment-1691476-12.patch30.95 KBchaby
#12 subs-subs_payment_payment-1691476-11.patch30.86 KBchaby
#11 subs-subs_payment_payment-1691476-10.patch30.8 KBchaby
#10 subs-subs_payment_payment-1691476-9.patch30.44 KBchaby
#9 subs-subs_payment_payment-1691476-8.patch30.31 KBchaby
#7 subs-subs_payment_payment-1691476-7.patch28.85 KBchaby
#6 subs-subs_payment_payment-1691476-6.patch24.2 KBchaby
#5 subs-subs_payment_payment-1691476-5.patch11.16 KBchaby
#3 subs-subs_payment_payment-1691476-3.patch19.1 KBchaby
#1 subs-subs_payment_payment-1691476-1.patch19.08 KBchaby
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-1.patch19.08 KB
chaby’s picture

chaby CreditAttribution: chaby commented

Sorry forgot to say :

- used last dev release of payment module
with this patch to apply.

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-3.patch19.1 KB

minor fix

alexweber’s picture

alexweber CreditAttribution: alexweber commented
Assigned: Unassigned » alexweber
Status: Needs work » Needs review

Awesome, thanks!

I'm going to review this and I'll post back here!

chaby’s picture

chaby CreditAttribution: chaby commented
Status: Needs review » Needs work
FileSize
subs-subs_payment_payment-1691476-5.patch11.16 KB

ok thanks.

here an updated patch which include :

- updated README.txt
- store some data into payment object (subs type used and subs created/associated to the payment)
- add a mapping between payment ID and sub id associated
- little views support (relations between payment and subs)

I set this issue in"needs work" state as i was asking if we could :

- delete mapping between payment and subs created if one of this entity has been deleted (useless to keep track on an non-existent entity ? But if we have still one of two entities, better to keep it despite ?)
- improve views integration (not sure, as payment and subs have its own views type). For the moment, we could only retrieve IDs...and use it to display links to entities for example

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-6.patch24.2 KB

sorry ! missing to provide a merged patch !

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-7.patch28.85 KB

Hi, sorry new patch again...(mostly fix and review)

Thinking it should be better and more easy to maintains by opening a sandbox for versionning and asking for review when it will be more stable !

alexweber’s picture

alexweber CreditAttribution: alexweber commented

Thanks!

I haven't had any time this week but I'm planning to spend a few hours this weekend reviewing all your contributions to Subs.

I'll be in touch!

Thanks again! :)

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-8.patch30.31 KB

ok thank you !

An another patch which fix some issues and add some improvements

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-9.patch30.44 KB

Just some minor fix

chaby’s picture

chaby CreditAttribution: chaby commented
Status: Needs work » Needs review
FileSize
subs-subs_payment_payment-1691476-10.patch30.8 KB

Hi,

An another patch which add some improvements :
- keep track on payment error (don't use db rollback, except entity error)
- add possibility to rebuild the payment form when remote payment error occured
- remove redirect from finish callback which will bypass post-process (by killing php execution to send http headers)

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-11.patch30.86 KB

An another simple patch to fix views handler field defined to use float handler for amount and tax rate fields.

chaby’s picture

chaby CreditAttribution: chaby commented
FileSize
subs-subs_payment_payment-1691476-12.patch30.95 KB

A new patch which used a new payment patch (still in needs works) integration.

alexweber’s picture

alexweber CreditAttribution: alexweber commented

Awesome, thanks Chaby! (ps - did u get my email?)

chaby’s picture

chaby CreditAttribution: chaby commented
Status: Needs review » Needs work
FileSize
subs-subs_payment_payment-1691476-13.patch48.05 KB

Hi,

(ps - did u get my email?)

Yes, and hope having news soon :-) !

Here an another patch which deals with offsite payment method.
But it would have to be review (to have a generic ways to deals with it through payment ?).

It also add some improvements, including cron task such as deleting/cancelling pending payment which haven't been cancel or complete with offsite payment (and not already updated by contextual module), provide hooks intented to other context module and so on...

chaby’s picture

chaby CreditAttribution: chaby commented
Assigned: alexweber » chaby
Status: Needs work » Closed (won't fix)

As see with alexweber, live into its own project now.

Currently available in sandbox.