Duplicates: Empty fields & Field Empty Text [#1696266]

From their descriptions, Empty fields and Field Empty Text provide the same functionality.

Although beyond hook_field_attach_view_alter() their approach seems to be different, both modules are in early stage of development (read: brand new), and there still might be a chance to join forces and reduce duplication.

Comments

Comment #1

Alan D. CreditAttribution: Alan D. commented 22 July 2012 at 14:18

Title:

Empty fields & Field Empty Text - consider merging?

» Duplicates: Empty fields & Field Empty Text

Yep, this has been sandbox for a while (June 25, 2012) and only just promoted so no surprise that rypit missed it before publishing his on July 20, 2012.

From the looks of it, there is identical code for the text options between the two.

Feature comparisons,

Feature	Empty Fields	Field Empty Text
Provide checks on fields with data but no value	Yes	No
Provide text replacement	Yes	Yes
Token support	Yes	No
Use Field Defaults	Yes	No
Use custom callbacks	Yes	No

Differences, Empty Fields uses the display settings (more flexible but has dependency on field_formatter_settings that plugs holes in the core field hook api), Fields Empty Text uses the instance settings.

Comment #2

rypit CreditAttribution: rypit commented 23 July 2012 at 02:40

Status:

Active

» Needs work

Thanks Alan, looking forward to working with you. Field Empty text will be obsolete with a 2x release of Empty Fields, if you are cool with the ideas we've been discussing. I've updated the field empty text project page to reflect this.

Comment #3

Alan D. CreditAttribution: Alan D. commented 23 July 2012 at 02:56

Status:

Needs work

» Fixed

Cool, I was dreading updating that site. Remember I'm happy to move ownership, I've got enough modules to my name as it is already!

Benefits, your name is shown at the top "Posted by Alan D. on June 25, 2012 at 2:17am" and the issues show in your projects tab (and would be removed from mine). Other than that, a single commit will show you up as a maintainer in all other areas.

mrstrean is one of the developers at work, but I'd not expecting him to contribute in any meaningful way.

Just in case you haven't noticed, flagging the issue as "Fixed" triggers a two week window where the issue is visible. This is helpful in preventing duplicates. After the two weeks, the issue is programmatically closed.

Looking forward to your idea's on the plugin thing. This could be very simple to extend out the callbacks out, dropping the hard coded options, and re-adding these as a form settings callback via the plugin settings (but this is just me talking off the top of my head, I haven't put any thought into it.)

I'll go with t() for the meantime, but it is about time I looked at i18n_strings module. We can switch to this latter and keep the i18n boys happy (I work with webflo in the countries project)

Comment #4

Alan D. CreditAttribution: Alan D. commented 23 July 2012 at 02:59

t()

can be a quick commit to get yourself listed on the maintainers tab.

And another, update the README.txt authors, another cheap commit :)

Comment #5

rypit CreditAttribution: rypit commented 23 July 2012 at 14:25

Thanks again Alan. I look forward to starting this tonight. I've updated field_empty_text to reflect that empty fields should be the module to use for this type of thing. Look forward to seeing what we can come up with. If you'd like to get rid of ownership of this, I wouldn't mind taking it from you, but again no worries.

Cheers