Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As a followup to #1197622: My account link / menu item, it would be good to show a message letting the user know that the "My account" link won't be shown to anonymous users.
Comment | File | Size | Author |
---|---|---|---|
#3 | My-account-menu-link--enabled.png | 36.69 KB | marissam |
#3 | My-account-menu-link--disabled.png | 35.11 KB | marissam |
#3 | menu.admin_.inc-code-changes-present.png | 177.89 KB | marissam |
drupal-my-account-menu-hint.patch | 1.15 KB | lyricnz | |
Comments
Comment #1
Gaelan CreditAttribution: Gaelan commentedManual testing for this patch. You can find steps for manual testing here.
Comment #2
marissamI am going to try to test this manually. [NYCCamp sprint]
Comment #3
marissamThis patch code seems to already be part of codebase Drupal 8.x and Drupal 7.
Steps I took:
- Fetched fresh instance of Drupal 8.x on 7/14/2013 using Git
- Installed Drupal
- Logged in as Admin to instance
- Navigated to Menu>Structure>Menus
- For "User account menu," clicked "Edit menu button"
- Observed that the text "logged in users only" appears by the menu item "My account" when the "My account" menu item is enabled.
Screenshot:
- deselected the enabled checkbox and saved the menu
- Observed that the text "disabled" appears by the menu item "My account" when the "My account" menu item is disabled.
Screenshot:
- inspected the patch file and found code that appeared to provide those text strings to the user for the respective states.
- inspected the file referenced in the patch, core/modules/menu/menu.admin.inc, and found the code already present.
Screenshot of Eclipse view of this file:
Because I already have some Drupal 7.22 installations, I checked those and saw the same behavior as listed above in the UI. I also inspected the file modules/menu/menu.admin.inc and saw the patch code present in that file.
Comment #4
marissamIn issue #1197622: My account link / menu item, comment #1197622-42: My account link / menu item indicates that the patch in comment #1197622-39: My account link / menu item was committed to the 8.x branch. Commit hash is 203b4e61.
Also, in the same issue #1197622: My account link / menu item, comment #1197622-46: My account link / menu item indicates that the patch in comment #1197622-43: My account link / menu item was committed to the 7.x branch. Commit hash is 2cbf221c in release 7.17.
Comment #5
marissamClosing as duplicate of #1197622: My account link / menu item