Make translation language changeable

Thank you! it worked with me and all good.

+++ b/entity_translation.module
@@ -152,6 +152,8 @@ function entity_translation_entity_info_alter(&$entity_info) {
+      // Add 'language' entity key to make sure the entity is saved with the correct source language
+      $entity_info[$entity_type]['entity keys']['language'] = 'language';

This is not something I'm inclined to do, because not every entity has a language property. Why is this needed here?

+++ b/includes/translation.handler.inc
@@ -742,8 +742,8 @@ class EntityTranslationDefaultHandler implements EntityTranslationHandlerInterfa
-        $form['language']['#options'][$langcode] = $languages[$langcode]->name;
-        $form['language']['#default_value'] = $langcode;
+        $form['language']['#options'][$form_langcode] = $languages[$form_langcode]->name;
+        $form['language']['#default_value'] = $form_langcode;

This is changing the original entity language, many things would be screwed by this I think.

Instead I think we need a copy of the language widget, something like:

<?php
$form['form_language'] = $form['language'];
$form['form_language']['#default_value'] = $form_langcode;
$form['language'] = array(
  '#type' => 'value',
  '#value' => $langcode,
);
?>

Here's a patch based on the plach's suggestion in #8.

If we want to support also changing the translation language we need an active language selector. However it's not clear from the UX folks which direction is the desired one.

Right, patch above only fixes the issue with the disabled language dropdown being confusing...

@plach do you think we can postpone the feature for changing the translation language, and go ahead with fixing the current issue? I'd also be happy with removing the dropdown completely, but I remember reading somewhere that it has to stay (I don't remember why).

I think there is a value in having the entity language always shown for information, but it should be labelled as such. If we want to change the translation language the selector has to be active. The patch in #8 does not improve UX in any of the two directions IMHO.

EDIT: As a stop gap I'd just rename the "Language" label to something like "Original language".

Okay, so shall we just adjust the title for now?

Yep, let's leave this open after commit for future improvements if we decide to make the translation language changeable.

Committed #12. Back to Active.

Actually this is postponed to the discussion in #1282018: Improve UX of language-aware entity forms.