Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I fixed this by changing the iframe resize callback registration from the jQuery UI tabs 'show' event to the 'load' event. The load event is fired after the tabs have rendered, so when we calculate the height of the content in the iframe, it includes the padding around the tabs.
I also removed the white background from #media-browser-page because it sticks out from behind the overlay content and looks bad.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1701732_media-browser-overlay-hidden-content_3.patch | 542 bytes | jessebeach |
| #3 | 1701732_media-browser-overlay-hidden-content_2.patch | 926 bytes | jessebeach |
| #1 | 1701732_media-browser-overlay-hidden-content_1.patch | 1.39 KB | jessebeach |
Comments
Comment #1
jessebeach CreditAttribution: jessebeach commentedThe patch.
Comment #3
jessebeach CreditAttribution: jessebeach commentedSorry, the patch above was created against an already-patched version of the module.
I rerolled it against the 7.x-1.x branch.
Comment #4
jessebeach CreditAttribution: jessebeach commentedSetting to Needs review
Comment #6
jessebeach CreditAttribution: jessebeach commentedTrying this again. No idea why these patches aren't applying.
Comment #8
jessebeach CreditAttribution: jessebeach commentedI really don't understand why this patch isn't applying. It's a one line change that makes the overlay browser look not broken. Just making the change and committing it would be lovely. Thank you!
Comment #9
jessebeach CreditAttribution: jessebeach commentedComment #10
attiks CreditAttribution: attiks commentedAFAIK there's nothing wrong with your patch the tests are having problems with undefined variables.
Comment #11
tim.plunketthttp://qa.drupal.org/pifr/test/309818 shows its passing...
Comment #12
attiks CreditAttribution: attiks commented@tim, it did't when I had a look, very strange ...
Comment #13
Dave Reid@jessebeach: Could you give me maybe a couple of instructions on how to produce the problem that this fixes? I'm not sure I quite understand from the original report.
Comment #14
acrollet CreditAttribution: acrollet commented@Dave Reid to reproduce the problem, open the media browser while logged in as a user that only has permission to see the 'Library' tab. (i.e. doesn't have, I believe, the "Edit media" permission.) Patch works nicely for me.
Comment #15
jessebeach CreditAttribution: jessebeach commented@Dave Reid, were you able to reproduce the issue with @acrollet's instructions?
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedThanks i was able to reproduce, submit buttons where hidden..it also fixed the height for admin users as well, before the patch the bottom border was hidden.small deal but i am glad hehe:)
commited
Edit: i tried the patch on 7.x-2.x and it breaks the browser. so i ll leave
show:as is there