I fixed this by changing the iframe resize callback registration from the jQuery UI tabs 'show' event to the 'load' event. The load event is fired after the tabs have rendered, so when we calculate the height of the content in the iframe, it includes the padding around the tabs.

I also removed the white background from #media-browser-page because it sticks out from behind the overlay content and looks bad.

Files: 
CommentFileSizeAuthor
#6 1701732_media-browser-overlay-hidden-content_3.patch542 bytesjessebeach
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]
#3 1701732_media-browser-overlay-hidden-content_2.patch926 bytesjessebeach
FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 0 fail(s), and 12 exception(s).
[ View ]
#1 1701732_media-browser-overlay-hidden-content_1.patch1.39 KBjessebeach
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1701732_media-browser-overlay-hidden-content_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

StatusFileSize
new1.39 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1701732_media-browser-overlay-hidden-content_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

The patch.

Status:Needs review» Needs work

The last submitted patch, 1701732_media-browser-overlay-hidden-content_1.patch, failed testing.

Version:7.x-1.0» 7.x-1.x-dev
StatusFileSize
new926 bytes
FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 0 fail(s), and 12 exception(s).
[ View ]

Sorry, the patch above was created against an already-patched version of the module.

I rerolled it against the 7.x-1.x branch.

Status:Needs work» Needs review

Setting to Needs review

Status:Needs review» Needs work

The last submitted patch, 1701732_media-browser-overlay-hidden-content_2.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new542 bytes
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es).
[ View ]

Trying this again. No idea why these patches aren't applying.

Status:Needs review» Needs work

The last submitted patch, 1701732_media-browser-overlay-hidden-content_3.patch, failed testing.

I really don't understand why this patch isn't applying. It's a one line change that makes the overlay browser look not broken. Just making the change and committing it would be lovely. Thank you!

Status:Needs work» Needs review

AFAIK there's nothing wrong with your patch the tests are having problems with undefined variables.

@tim, it did't when I had a look, very strange ...

@jessebeach: Could you give me maybe a couple of instructions on how to produce the problem that this fixes? I'm not sure I quite understand from the original report.

Status:Needs review» Reviewed & tested by the community

@Dave Reid to reproduce the problem, open the media browser while logged in as a user that only has permission to see the 'Library' tab. (i.e. doesn't have, I believe, the "Edit media" permission.) Patch works nicely for me.

@Dave Reid, were you able to reproduce the issue with @acrollet's instructions?

Status:Reviewed & tested by the community» Fixed

Thanks i was able to reproduce, submit buttons where hidden..it also fixed the height for admin users as well, before the patch the bottom border was hidden.small deal but i am glad hehe:)

commited

Edit: i tried the patch on 7.x-2.x and it breaks the browser. so i ll leave show: as is there

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.