Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are a variety of sub-issues under this, including:
#1698986: Add new projects to Spark for sprint 2 work
#1697586: Aloha Editor + Spark sprint: Drupal-specific Aloha Editor plug-ins still need to be merged/cherry-picked
#1686568: Nested editables: macro filter tags (first: token_filter)
#1702254: [Meta] As a content editor, I want to be able to caption images and align them through the WYSIWYG toolbar
#1701522: Add our own formattings transformation handler (i.e. when pasting, always use <strong>, never use <b>)
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 1702248-9.patch | 1.02 KB | jessebeach |
| #9 | 1702248-pull_request_642-9.patch | 1.36 KB | jessebeach |
| #6 | 1702248-pull_request_642-6.patch | 1.02 KB | Wim Leers |
| #6 | 1702248-pull_request_643-6.patch | 1.55 KB | Wim Leers |
| #5 | 1702248-5.patch | 768 bytes | Wim Leers |
Comments
Comment #1
Wim LeersRemoving #1701618: Range errors when using CaptionedImage plug-in , replacing it with #1702254: [Meta] As a content editor, I want to be able to caption images and align them through the WYSIWYG toolbar.
Comment #2
Wim LeersTo get copy/paste plus
<strong>instead of<b>to work well, we'll also need #1701522: Add our own formattings transformation handler (i.e. when pasting, always use <strong>, never use <b>).Comment #2.0
Wim LeersUpdated issue summary.
Comment #3
Wim LeersBugs in edit/edit_aloha fixed while working on this, both related to edit assuming edit_aloha is enabled:
- http://drupalcode.org/project/edit.git/commit/2d52cc6
- http://drupalcode.org/project/edit.git/commit/e1785bf
Comment #4
Wim LeersBugs encountered when using jQuery 1.7, which Jesse just added the other day to be able to have cleaner code in the Layouts code:
- http://drupalcode.org/project/edit.git/commit/5a83227
- http://drupalcode.org/project/edit.git/commit/4418cc4
- http://drupalcode.org/project/edit.git/commit/11c38c8
- http://drupalcode.org/project/edit.git/commit/074e39e
And one more bug that I found that wasn't due to jQuery 1.7:
- http://drupalcode.org/project/edit.git/commit/0ac68d5 (when you changed a field through an in-place form on a non-node page, the "Save" button wouldn't become blue/clickable because no changes were being detected)
Comment #5
Wim LeersComment #6
Wim LeersComment #7
Wim LeersUploaded patches are to be used by our make file:
- #5: necessary to be able to override their custom UI
- #6: pull requests that have not yet been merged into a release that is available for download
All are used in http://drupalcode.org/project/spark.git/commit/3b1c0f5.
Comment #8
webchickRemaining wrap-up steps:
1) Make the default filtered HTML format look like https://dl.dropbox.com/u/80682862/d.o/2012/spark%20edit%20wysigyg%20text...
2) add some img with a data-caption and data-align atrribute to the example node body
I'm going to try and knock this out.
Comment #9
jessebeach CreditAttribution: jessebeach commentedTwo patches weren't applying so I've rerolled them.
Comment #10
Wim Leers@jessebeach: can you describe the differences between my patches and yours? I really would like to understand what went wrong there. (And I'd also like to understand why it did work on my machine … repeatably.)
Comment #11
webchickMoving this to the Spark queue since it's a meta issue.
Comment #12
webchickWOOHOO. Ok, apart from #1718336: Emphasis and Strong are getting a Bold icon for some reason, which we need to fix before I can tag a new Spark release, I believe this sucker is D-O-N-E! *So* exciting to see things coming together like this!
Comment #13
webchickSorry, here are the relevant commits:
http://drupalcode.org/project/spark.git/commitdiff/530ce6021a3cb1cb4adf6...
http://drupalcode.org/project/spark.git/commitdiff/de28c744a81983c99b386...
http://drupalcode.org/project/spark.git/commitdiff/cb54fb85aa13218e9917f...
Comment #14
Wim LeersShould all meta issues always live in the Spark issue queue maybe?
Comment #15
jessebeach CreditAttribution: jessebeach commented@Wim Leers, re: #1702248-10: [Meta] As a site builder, I would like to download a version of Spark with the WYSIWYG tools all ready to go, it was just an issue of line numbers. The changes in your original patches seemed to be 25 lines or so higher in the code than when I rebuilt them. Maybe the Aloha folks added some code and rebuilt the CDN released version of the code between when you rolled them and when I tried to apply them.
Comment #16
Wim Leers#15: hm, ok, weird. Simple line offsets have never caused patches to fail in the past for me though. Very weird. Thanks for letting me know :)
Comment #17.0
(not verified) CreditAttribution: commentedUpdated issue summary.