While using imagecache_actions and system_stream_wrapper [http://drupal.org/project/system_stream_wrapper] together, there is a warning about expecting a string and getting an array instead [or vice-versa]. From what I can tell, the stream wrapper that is defined in imagecache_actions isn't being used anywhere, and simply commenting it out (and disabling system_stream_wrapper) does not "nerf" the functionality of defining a file for overlays. I am asking that the stream wrapper function, included as part of the imagecache_actions module, be reassessed or even removed in lieu of either being dependent on system_stream_wrapper or simply allowing a path to be defined using core stream wrappers or as a relative/absolute path.

To duplicate the warning message, simply download both imagecache_actions and system_stream_wrapper and enable them both.

Comments

fietserwin’s picture

fietserwin
Location Le Mont-Dore
CreditAttribution: fietserwin commented
Version: 7.x-1.0 » 7.x-1.x-dev
Assigned: Unassigned » fietserwin

I was not aware of the system_stream_wrapper module. I think it is best to follow your suggestions: install it if you want to use it, or do not use it. I will follow up on this somewhere in the coming weeks.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
CreditAttribution: fietserwin commented
Assigned: fietserwin » Unassigned
Status: Active » Fixed

Removed the stream wrapper class, its registration hook, and added some documentation about the system stream wrapper module.

Thanks again for mentioning this module to me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Virbius’s picture

Virbius CreditAttribution: Virbius commented

I've just done a major update to a site, including updating this (ImageCache Actions) module from 7.x-1.0 to 7.x-1.1 . Before the update in the Modules list under Features "Image Effects Text test" didn't require the module "System_stream_wrapper". After the update it does, and I didn't know to add the "System_stream_wrapper" module the update process hung complaining it was missing. I managed to work out that it was the latest "ImageCache Actions" module that included the "Image Effects Text test" feature, reverse its update, and complete the system update. I then disabled the test feature, and again updated the actions module. That was when I saw that it required the wrapper module.

There is no Dependencies section in the ImageCache Actions project page (like there is in http://drupal.org/project/image_optimize_effect) and it would be really useful if there was one. Could one be added, and kept up to date? Thanks.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
CreditAttribution: fietserwin commented

I know that adding dependencies in upgrades can be a pain in the ass. (How many sites I have updated with i18n that started to depend on variable, or a newer version of variable that was not yet detected by the update system itself ...).

So I guess you are right and thus I updated the release notes and the project page. Thanks for reporting.