Bug when using Group URL handler for context detection [#1703054]

When I set the context detection for group URL to true I got an error on og_get_group function in og_extras_context_handler_url.

I tried to find a way around and what I found is the following modification :

/**
 * Context handler; Get groups from URL.
 */
function og_extras_context_handler_url() {
  $context = array();
  if (arg(0) == 'group' && is_numeric(arg(1))) {
    $context = array('node'=>array(arg(1)));
/*
    $group = og_get_group('group', arg(1));
    if (!empty($group) && !empty($group->nid)) {
      $context = array($group->nid);
    }
*/
  }
  return $context;
}

Now it works. I don`t really know if it`s a bug and if it`s the best way to correct it.
What do you think?

Comment	File	Size	Author
#3	og_extra.module-issue-1703054.patch	717 bytes	wadmiraal

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Thithi32 CreditAttribution: Thithi32 commented 27 July 2012 at 19:03

Title:

Bug using og_get_group when using Group URL handler (context detection)

» Bug when using Group URL handler for context detection

Comment #2

BrightBold

she/her

English

Boston, MA

CreditAttribution: BrightBold commented 6 February 2013 at 14:02

@Thithi32 — Thanks! You're a lifesaver. I also was getting the error
Fatal error: Call to undefined function og_get_group() in /mysite/sites/all/modules/og_extras/og_extras.module on line 145 when visiting a page where context detection was required. I had poked around in the code looking for the source of the og_get_group() function and couldn't find it anywhere in OG Extras, OG core, or OG Context, so I don't know if it has been removed or if I was just looking in the wrong place. At any rate, your modification solves the problem.

Comment #3

wadmiraal CreditAttribution: wadmiraal commented 21 August 2013 at 09:56

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Active	» Needs review

File	Size
og_extra.module-issue-1703054.patch	717 bytes

Error is still on dev as well.

The following patch corrects the problem by using the updated OG API. Only use the patch if you're using OG 2 or higher. Also, note this patch only applies to node groups (which is what you would use in 99% of cases anyway).

@maintainers
You should consider creating a 7.x-2.x branch, which would follow the OG core upgrades. This patch could then be applied to that branch. Applying it to your current branch would be a bad idea, as it would break backward compatibility.