Disable registration email verification when user registered using invited email

Actually the user is already unblocked by the invite module, which would normally be done by clicking the activation link in the second email. So, if I'm not wrong, all we have do is to prevent getting the activation email sent. This could be done by temporarily switching email verification off in hook_user(). I've attached a patch but didn't test it for now.

This doesn't work, as we're bailing out in the middle of user_save(). Look in user.module for user_module_invoke('insert', ...) -- everything after that line is lost because we'll never return...

The only real way seems to put the password field back in the register form. This is what I've tried in the new patch, email verification is now (temporarily) switched off before user_register_submit() is processed. Tricked this way, it stores the entered password, still sends the welcome email (which is good IMO) and finally logs the user in.

The only thing that bothers me is the way it's done: if a third party module also modifies the register form's #submit property and (for example) inserts its own handler (and therefore removes ours), then the user enters a password but it won't be saved -- which is bad.

An alternative (and possibly cleaner) way to achieve the same result could be checking in hook_init() if the session variable is set && we're at user/register then switch email verification off. That way we could get rid of the fragile #submit handler stuff.

Note: this is against DRUPAL-5 branch. Tested, seems to work.

Just implemented the alternative way and it turns out to look like the very first patch, no more form_alter no submit handler fuzz. Seems to work fine, too. IMO this is the way to go, what do you think?

With "bail out" I meant drupal_goto() which will never return (issues a Location header and exits).

Creating our own register handler would mean lots of duplicated code, if we want to keep all the functionality that Drupal offers: third party modules hooking into the register form, for example (profile/nodeprofile asking for required extra fields). I doubt this will be possible without breaking something.

While discussing this issue with sun, he came up with another problem: this issue is essentially only true if the email address that the user enters on the registration page actually is the same as the email the invitation was initially sent to. So the latest patch still requires some additional checks that eventually switches email verification back on if the emails differ.

Sam-ka: I tested the latest patch and it seems to work as described. WRT checking to make sure the email address matches the one the user was invited with, I think there are a fair number of people who will want to use a different email address than the one someone invited them with I think we may want to support changing email addresses on registration even if it means sending out a confirm email address.

but it sounds like you'd like to have them enter in a password upon registration, which is friendlier anyway

It was may intention by then. In the meantime I'm a bit unsure, because it isn't as simple as I first thought. So, if we can move the drupal_goto() into the form's #destination, that is, choose the way of letting the user change its password right after registration, then this seems to me to be currently the cleanest solution (ie. the behavior is still similar to what would normally happen).

Marked #313365: Logintoboggin and Invite module incompatibility as a duplicate of this issue.

IIRC, this issue was simply "too much" for D5 with its hardcoded execution flow. Let's see what's possible in D6.

I'm also facing this issue. I'm assuming since it's been so long that we've moved on to other priorities.

+1 subscribing
To confirm, there is no patch to test for 6.x-2.x-dev correct?
Thanks!

+subscribing as well.

Hi smk-ka,

I use Logintoboggan module and from reading this thread I see a huge benefit of this new feature.
Changed Category to 'feature request' and hope to help out with testing.

Thanks!

What happens when the user doesn't want to use the invited email?

I'm doing something similair to the patch in a custom module, but with some additional handling for the case of users using different email addresses and decline the invite.

I'm good with the current patch (method works for me, haven't tested the actual patch, I think it needs to be updated for d6), but just putting it this here as consider.

/**
 * Implementation of hook_init().
 */
function mymodule_init() {
  // Change the form to not needing verifcation.
  // We could do this using a lot of ugly form_alters, but want the other email.
  if ($_GET['q'] == 'user/register' && !empty($_SESSION[INVITE_SESSION])) {
    global $conf;
    // Decline invite
    if ($_GET['decline']) {
      unset($_SESSION[INVITE_SESSION]);
    }
    else {
      if (!empty($_GET['different_email'])) {
        $conf['user_email_verification'] = 0;
      }
    }
  }
}

/**
 * Implementation of hook_form_alter() of user_register.
 */
function mymodule_form_user_register_alter(&$form, $form_state) {
  if ($invite = invite_load_from_session()) {
    if (empty($invite->data['different_email'])) {
      if (!empty($form['account'])) {
        $use = &$form['account'];
      }
      else {
        $use = &$form; 
      }
      $use['mail']['#access'] = FALSE;
      $use['email'] = array(
        '#type' => 'item',
        '#value' => $use['mail']['#default_value'],
        '#title' => $use['mail']['#title'],
        '#weight' => $use['mail']['#weight'],
        '#description' => t("<a href='!diff_url'>Change Email</a> If you use a different email address than the one you were invited with, you will have to verify this new address before you can log in.", 
          array(
            '!diff_url' => url('user/register', array(
              'query' => array(
                'different_email' => 1,
              ),
            )),
          )
        ),
      );
    }
    $form['cancel'] = array(
      '#type' => 'markup',
      '#value' => l(t('Decline Invite'), 'user/register', array(
        'title' => t('If you do not want to use this invite, click here.'),
        'query' => array(
          'decline' => 1
        ),
      )),
      '#weight' => $form['submit']['#weight'] - 2,
    );
  }
}

edit: oh and need to use the new variable in #651264: Path to the registration page configurable instead of 'user/register'.

I wanted similar behavior in 7.x. This is what I did:

function MYMODULE_form_user_register_form_alter(&$form, &$form_state, $form_id) {
  $invite = invite_load_from_context();
  if (!empty($invite) && invite_validate($invite) == INVITE_VALID) {    
    // Get selected email address
    if (isset($form_state['input']['mail'])) {
      $mail = $form_state['input']['mail'];
    }
    else {
      $mail = $form['account']['mail']['#default_value'];
    }
    
    if ($mail == $invite->email) {
      // Disable verification if they registered with the same address
      // as the invite
      $GLOBALS['conf']['user_email_verification'] = 0;
    }
  }
}