Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There are two minor issues with the above:
fonts_com_project
andfonts_com_filter_choices
variables are deleted inhook_disable()
instead ofhook_uninstall()
; this is probably not a good idea as one often temporarily disables modules when trying to debug some problem, and having to enter settings again is a needless hassle;- on the other hand,
fonts_com_token
variable is not deleted at all.
A patch is on its way.
Comment | File | Size | Author |
---|---|---|---|
#1 | fontyourface-Fonts_com_uninstall_procedures-1703410-1.patch | 1015 bytes | Drave Robber |
Comments
Comment #1
Drave Robber CreditAttribution: Drave Robber commentedHere's the patch.
On a second thought (or rather second check), the former issue (variables being deleted in
hook_disable()
) is present also infontdeck.install
andtypekit_api.install
, so it might make sense to fix them all at once (if this should be fixed at all, of course).In my quick testing of uninstall procedures, there was no leftover stuff other than
fonts_com_token
variable (which was why I jumped onfonts_com.install
only).Comment #2
sreynen CreditAttribution: sreynen commentedThis is committed. If you want to make a patch for the other two, that's fine. If not, I'll try to remember to move those deletes next time I'm doing something in those files.
Comment #3
Drave Robber CreditAttribution: Drave Robber commentedFollowup: #1705778: Improve uninstall for Fontdeck and Typekit API