Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The crss feed is not shown if we're on a front page and current path is 'frontpage'.
case COMMENTRSS_SITE_FRONT_AND_NODE_PAGE:
if (!drupal_is_front_page() || (current_path() != 'node')) {
// Only break if not front page and not node page.
break;
}
The comment and the code contradict each other. It seems the comment is correct.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | commentrss-comment-expose-front-1704724-13-D7.patch | 493 bytes | davic |
| #3 | commentrss-feed_front-1704724-3-D7.patch | 506 bytes | davic |
| commentrss_fix_condition.patch | 493 bytes | scito |
Comments
Comment #1
scitoOr may be the order of
COMMENTRSS_SITE_FRONT_AND_NODE_PAGEandCOMMENTRSS_SITE_FRONT_PAGEshould be exchanged.The possible cases should be examined.
Comment #2
rodrigoeg CreditAttribution: rodrigoeg at CI&T commentedThe patch is working fine. Only the patch file name is not following the standards mentioned on this page https://www.drupal.org/patch/submit
I think this approach is fine (I am not the maintainer of the module), and it also follows the implementation mentioned on the comments "Only break if not front page AND not node page."
Comment #3
davic CreditAttribution: davic at CI&T commentedFixed name of the patch submitted by scito according to standards.
Comment #4
davic CreditAttribution: davic at CI&T commentedFixed the name of the patch submitted by scito , ready for review.
Comment #13
davic CreditAttribution: davic at CI&T commentedRemade the patch made by scito due to test fail on both previous patches.
Comment #14
davic CreditAttribution: davic at CI&T commentedReworked the patch scito made due to test fail.
Comment #19
davic CreditAttribution: davic at CI&T commentedTest CI error, but patch is working fine. May need patch test reroll.
Comment #20
larruda CreditAttribution: larruda at CI&T commentedThis module does not implement its own tests so I have disabled Automated Testing for it on DrupalCI.
Changing it back to Needs Review. Someone please go ahead and review it.
Thanks!
Comment #21
Diego_Mow CreditAttribution: Diego_Mow as a volunteer commentedTested and working fine. RTBC
Comment #23
larruda CreditAttribution: larruda at CI&T commentedThank you guys!
Comment #24
Diego_Mow CreditAttribution: Diego_Mow as a volunteer commentedComment #25
larruda CreditAttribution: larruda at CI&T commented@Diego_Mow, I have just committed this to the dev branch and now it's fixed. Any reason to change it back to RTBC?
Comment #26
larruda CreditAttribution: larruda at CI&T commented